Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7946 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 1 -1
Lines 43 8 -35
=========================================
- Hits 43 8 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
taxable_roth_conversionsinput variable for tax-only Roth conversion amountsWhy
Downstream retirement modeling needs a way to represent direct Roth conversions that affect tax gross income without automatically treating them as spendable retirement-distribution income for means-tested benefits.
This keeps a cleaner separation between:
That separation matches the legal structure more closely:
42 U.S.C. 1382a, not IRS gross income20 CFR 416.1103(c)7 CFR 273.9; retirement benefits are listed in unearned income under7 CFR 273.9(b)(2), while nonrecurring lump-sum payments are excluded from income under7 CFR 273.9(c)(8)This PR does not try to fully resolve every Roth-conversion treatment question for benefit programs. It just avoids forcing a tax-only Roth conversion input through
retirement_distributions.Verification
uv run policyengine-core test policyengine_us/tests/policy/baseline/household/income/person/retirement/taxable_roth_conversions.yaml -c policyengine_usuv run policyengine-core test policyengine_us/tests/policy/baseline/gov/irs/irs_gross_income.yaml -c policyengine_usuv run policyengine-core test policyengine_us/tests/policy/baseline/gov/ssa/ssi/income/ssi_unearned_income.yaml -c policyengine_usuv run policyengine-core test policyengine_us/tests/policy/baseline/gov/usda/snap/income/snap_unearned_income.yaml -c policyengine_usuv run python -m py_compile policyengine_us/variables/household/income/person/retirement/taxable_roth_conversions.py policyengine_us/tools/default_uprating.py