Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3385 +/- ##
==========================================
+ Coverage 72.20% 72.58% +0.38%
==========================================
Files 56 56
Lines 2425 2477 +52
Branches 423 431 +8
==========================================
+ Hits 1751 1798 +47
- Misses 595 598 +3
- Partials 79 81 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update PolicyEngine US from 1.632.5 to 1.633.2.
This PR does not change the v1 API's
policyengine_ukpin.Why tests were failing
The failing
test_utahcheck was not caused bypolicyengine-us 1.633.2itself.The legacy simulation gateway was reading shared Modal dicts that had been overwritten by
policyengine-api-v2-alpha, so requests forus 1.633.2were resolving topolicyengine-v2-us1-633-2-uk2-75-1instead of the oldpolicyengine-simulation-*app family.The old gateway calls
run_simulation, and that app does not expose it. The live gateway error was:Function 'run_simulation' not found on App 'policyengine-v2-us1-633-2-uk2-75-1'The shared-registry root cause is being fixed in:
Legacy simulation API state
The legacy simulation API already owns the UK
2.78.0pairing:policyengine-api-v2mainalready pinspolicyengine-uk==2.78.0inprojects/policyengine-api-simulation/uv.locksimulation-api-uk-versions[latest] = 2.78.0simulation-api-uk-versions[2.78.0] = policyengine-simulation-us1-633-2-uk2-78-0The live registries have now been split so:
simulation-api-*entries point topolicyengine-simulation-*policyengine-api-v2-alphausesapi-v2-us-versions/api-v2-uk-versionsThis PR remains a US-only update in the v1 API repo.
What changed (1.632.5 -> 1.633.2)
Added
Changed
programs.yamlto reflect current modeled program coverage and pending in-progress program implementations across TANF, CCDF, LIHEAP, SSI state supplements, and Colorado OmniSalud.Fixed
Generated automatically by GitHub Actions and updated to document the registry collision / legacy routing fix.