Added type detection for home and lza. #1156
Open
Dalton-V wants to merge 2 commits intoPokemonAutomation:mainfrom
Open
Added type detection for home and lza. #1156Dalton-V wants to merge 2 commits intoPokemonAutomation:mainfrom
Dalton-V wants to merge 2 commits intoPokemonAutomation:mainfrom
Conversation
Dalton-V
force-pushed
the
home-type-detection
branch
from
2d8d855 to
5ebf6d0
Compare
Mysticial
reviewed
Apr 8, 2026
| } | ||
| } | ||
| ptr += words; | ||
| } |
Collaborator
There was a problem hiding this comment.
You can replace this entire double loop with:
sprite = filter_rgb32_range(
sprite,
0xff000000, 0xffffffff,
Color(0), false
);
Mysticial
reviewed
Apr 8, 2026
Mysticial
reviewed
Apr 8, 2026
| } | ||
|
|
||
|
|
||
| static void find_type_candidates( |
Collaborator
There was a problem hiding this comment.
This function looks similar to the SwSh one. I won't make you dedupe it since these are probably very specific to the game. But leave a comment saying that this taken from there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Pokemon Type reading for Gen 9. Currently used in box sorters for Home and LZA