frlg and rse min time for throw no sound#1153
Open
kichithewolf wants to merge 1 commit intoPokemonAutomation:mainfrom
Open
frlg and rse min time for throw no sound#1153kichithewolf wants to merge 1 commit intoPokemonAutomation:mainfrom
kichithewolf wants to merge 1 commit intoPokemonAutomation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shiny_detector.throw_if_no_sound();changed toshiny_detector.throw_if_no_sound(std::chrono::milliseconds(1000));This seems to fix the issue reported by Dhruv in this thread.I was only able to inconsistently replicate in FRLG Legendary Reset, so I tried with the other audio-required programs as well. In Area Zero Platform I was able to do it twice (see video here for #2) but only by causing an encounter right away by starting on the platform, which was similar to how the shiny detector for FRLG in handle_encounter() doesn't detect for very long. Plus, attempting to replicate in other programs (LZA Overworld Reset and LA Alpha Crobat Hunter) that use throw_if_no_sound() failed. The other programs all have the audio detector running for longer periods of time, which is why I think this fixed it.