Fix bugs in compute quantities#2218
Conversation
unalmis
requested review from
a team,
YigitElma,
ddudt,
dpanici,
f0uriest and
rahulgaur104
and removed request for
a team
Co-authored-by: Kaya Unalmis <kayaunalmis@proton.me>
Co-authored-by: Kaya Unalmis <kayaunalmis@proton.me>
YigitElma
left a comment
YigitElma
left a comment
There was a problem hiding this comment.
Looks good to me. This PR looks isolated from the other PRs; if so, I think we can merge this to master directly. Otherwise, it will have to wait for all the other ones.
rahulgaur104
left a comment
rahulgaur104
left a comment
There was a problem hiding this comment.
Minor questions. I agree with Yigit, this PR is completely independent of available energy so pointing and merging in master would be faster and more sensible.
I can approve without any delay if you point to master.
This is not how git works. If it points to master, all head PRs will be merged simultaneously. |
|
This will wait until head PRs are merged. |
Can any of the rest of the @PlasmaControl/desc-dev developers explain this to me? I don't understand what that sentence means. I thought if we pointed this PR to master all commits of this PR will be merged into master and then master can be merged into the new PR, inheriting the merged commits. |
| label="\\sqrt{g}(B^{\\theta} \\nabla \\zeta - B^{\\zeta} \\nabla \\theta)", | ||
| units="T \\cdot m^{2}", | ||
| units_long="Tesla * square meter", | ||
| label="\\sqrt{g}(B^{\\zeta} \\nabla \\theta - B^{\\theta} \\nabla \\zeta)", |
There was a problem hiding this comment.
Sign flip in the definition. @dpanici Does this match the DESC paper? Were you trying to code the new label or the old label.
This branch has the commits from When I was suggesting pointing this to the master, I was actually implying to create a new PR with cherry-picked commits from this one. But if Kaya doesn't want to do it, it can wait for the other ones. |
|
Thank, Yigit! That makes more sense but it is kind of confusing. Yeah, I can easily copy all these changes to a new PR in 10 minutes and point them directly to master. It's mostly name/label changes and some algebra corrections which would become relevant when generalized toroidal angle comes online but nothing that would cause anything to fail right now. We can wait as well. |
|
It will cause many merge conflicts if you duplicate my work into new PR. Don't do that |
3 participants
e_rho_rr,e_theta_rtt,e_zeta_rzz,iota_num_rr limit. and fix so that redl bootrap uses independent ion density gradient Te * d_ne_d_s + Ti * d_ni_d_s.