Conversation
pkheav
requested review from
a team and
websymphony
and removed request for
a team and
websymphony
Open
stakach
requested changes
Feb 23, 2021
Member
stakach
left a comment
stakach
left a comment
There was a problem hiding this comment.
These drivers should implement the Switchable interface
@kimburgess we should probably update your Extron Matrix driver to do the same
The switchable interface was brainstormed early on, so happy for updates to made to the interface too.
* chore(leviton): add debugging to acquisuite driver * chore(leviton): dig debugging lines Co-authored-by: Stephen von Takach <steve@place.technology> * chore(leviton): add better debugging to acquisuite driver Co-authored-by: Stephen von Takach <steve@place.technology>
* fix(leviton): final logic fixes * chore(leviton): crystal tool format
audio input query is unsupported by many models the checksum is incorrect for some firmware versions causing command retries
* Add twenty five live pro * Added 25Live Pro API wrapper * Add tests for the driver and add a room scheduler * Run the formatter * Remove the false data * Swap out the parameter builder for the STD alternative
…ncellation/prompting
fixes issue with redis pool
for analytics
Co-authored-by: Cameron Reeves <reeves.cameron@gmail.com>
we default this to stopped
|
@stakach can you please review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've ported 2/3 drivers from here but not here as it is just a simple extension of the driver p3000 driver.
I can port the presentation.rb driver if needed though as it is simple.
Closes #47