[#141]: Add v0.140.0 compat tests for encrypted credential storage#152
Open
delexw wants to merge 1 commit into
Open
[#141]: Add v0.140.0 compat tests for encrypted credential storage#152delexw wants to merge 1 commit into
delexw wants to merge 1 commit into
Conversation
Codex v0.140.0 (PRs #27504, #27535, #27539, #27541) migrated CLI auth and MCP OAuth tokens from plaintext files to an encrypted secret store, adding the `secret_auth_storage_configuration` config option. codex-trace reads only JSONL session files at ~/.codex/sessions/ and never reads credential files, auth token files, or Codex CLI config. The encrypted storage change is therefore invisible to the parser. Add three tests to document and guard this: - entry.rs: v0140_all_standard_entry_types_parse_correctly - entry.rs: v0140_session_meta_with_secret_auth_storage_configuration_does_not_panic - discover.rs: v0140_discover_sessions_with_secret_auth_storage_configuration_in_session_meta Fixes #141
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex v0.140.0 (PRs #27504, #27535, #27539, #27541) migrated CLI auth tokens and MCP OAuth credentials from plaintext files to an encrypted secret store, adding the
secret_auth_storage_configurationconfig option.codex-trace is not affected — it reads only JSONL session files at
~/.codex/sessions/and never reads credential files, auth token files, or Codex CLI config files from the Codex home directory. The encrypted credential storage change is therefore invisible to the parser; unknown fields insession_metaare silently ignored by theserde_json::Value-based loosely-typed parser.Changes
Added three compatibility tests to document and regression-guard this behaviour:
entry.rs:v0140_all_standard_entry_types_parse_correctly— verifies all standard JSONL entry types from a v0.140.0 session parse without errorsentry.rs:v0140_session_meta_with_secret_auth_storage_configuration_does_not_panic— verifies asession_metacarrying the newsecret_auth_storage_configurationandmcp_oauth_storagefields is parsed without errors (unknown fields are gracefully ignored)discover.rs:v0140_discover_sessions_with_secret_auth_storage_configuration_in_session_meta— verifiesdiscover_sessionscorrectly scans v0.140.0 sessions that include auth config fields insession_metaTest Results
All 264 Rust unit tests pass. All 135 frontend tests pass.
Fixes #141