Desert Shrublands #2967
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| .{ | ||
| .properties = .{ | ||
| .hot, | ||
| }, | ||
| .tags = .{ | ||
| .cactus, | ||
| .baobab, | ||
| }, | ||
| .validPlayerSpawn = false, | ||
| .music = "cubyz:EasternThought", | ||
| .chance = 0, | ||
| .fogDensity = 1.5, | ||
| .fogColor = 0xe9f2e2, | ||
| .ground_structure = .{ | ||
| "3 to 4 cubyz:sand", | ||
| }, | ||
| .stoneBlock = "cubyz:sandstone/base", | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| .{ | ||
| .minHeightLimit = 7, | ||
| .minHeight = 22, | ||
| .maxHeight = 40, | ||
| .maxHeightLimit = 50, | ||
| .minRadius = 256, | ||
| .maxRadius = 320, | ||
| .hills = 30, | ||
| .chance = 0.5, | ||
| .structures = .{ | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:tree/baobab/shrub", | ||
| .placeMode = .degradable, | ||
| .chance = 0.14, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:tree/baobab/small", | ||
| .placeMode = .degradable, | ||
| .chance = 0.05, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:cactus/saguaro", | ||
| .placeMode = .degradable, | ||
| .chance = 0.01, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:cactus/young", | ||
| .placeMode = .degradable, | ||
| .chance = 0.006, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:ground_patch", | ||
| .block = "cubyz:dirt", | ||
| .chance = 0.2, | ||
| .width = 4, | ||
| .variation = 6, | ||
| .depth = 3, | ||
| .smoothness = 0.2, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:flower_patch", | ||
| .blocks = .{"cubyz:tussock"}, | ||
| .chance = 0.08, | ||
| .width = 4, | ||
| .variation = 4, | ||
| .density = 0.2, | ||
| .priority = 0.1, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:simple_vegetation", | ||
| .chance = 0.05, | ||
| .block = "cubyz:ocotillo", | ||
| .height = 1, | ||
| .height_variation = 0, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:flower_patch", | ||
| .blocks = .{"cubyz:ocotillo"}, | ||
| .chance = 0.02, | ||
| .width = 4, | ||
| .variation = 4, | ||
| .density = 0.2, | ||
| .priority = 0.1, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:boulder", | ||
| .chance = 0.02, | ||
| .block = "cubyz:slate/cobble", | ||
| .size = 3, | ||
| .size_variance = 1, | ||
| }, | ||
| }, | ||
| } |
|
Contributor
There was a problem hiding this comment. Please make this more common, the biome needs more sparse areas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| .{ | ||
| .minHeightLimit = 7, | ||
| .minHeight = 32, | ||
| .maxHeight = 40, | ||
| .maxHeightLimit = 50, | ||
| .minRadius = 50, | ||
| .maxRadius = 70, | ||
| .hills = 20, | ||
| .keepOriginalTerrain = 1, | ||
| .structures = .{ | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:tree/baobab/shrub", | ||
| .placeMode = .degradable, | ||
| .chance = 0.06, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:cactus/saguaro", | ||
| .placeMode = .degradable, | ||
| .chance = 0.01, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:cactus/young", | ||
| .placeMode = .degradable, | ||
| .chance = 0.003, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:ground_patch", | ||
| .block = "cubyz:dirt", | ||
| .chance = 0.18, | ||
| .width = 5, | ||
| .variation = 6, | ||
| .depth = 3, | ||
| .smoothness = 0.1, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:flower_patch", | ||
| .blocks = .{"cubyz:tussock"}, | ||
| .chance = 0.23, | ||
| .width = 4, | ||
| .variation = 4, | ||
| .density = 0.2, | ||
| .priority = 0.1, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:simple_vegetation", | ||
| .chance = 0.09, | ||
| .block = "cubyz:ocotillo", | ||
| .height = 1, | ||
| .height_variation = 0, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:flower_patch", | ||
| .blocks = .{"cubyz:ocotillo"}, | ||
| .chance = 0.02, | ||
| .width = 4, | ||
| .variation = 4, | ||
| .density = 0.2, | ||
| .priority = 0.1, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:simple_vegetation", | ||
| .chance = 0.11, | ||
| .block = "cubyz:dry_grass_vegetation", | ||
| .height = 1, | ||
| .height_variation = 0, | ||
| }, | ||
| .{ | ||
|
Contributor
There was a problem hiding this comment. These tiny ground patches look weird and messy. You should make them a little wider, and I would recommend using sand with pebbles on it instead for a more natural look. 
|
||
| .id = "cubyz:ground_patch", | ||
| .block = "cubyz:pebbles:cubyz:sand", | ||
| .chance = 0.05, | ||
| .width = 1, | ||
| .variation = 1, | ||
| .depth = 1, | ||
| .smoothness = 0.6, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:boulder", | ||
|
Contributor
There was a problem hiding this comment. Similarily, there are a lot of these 1-block boulders which look silly. Try to prevent them from being only 1 block. 
|
||
| .chance = 0.02, | ||
| .block = "cubyz:slate/cobble", | ||
| .size = 3, | ||
| .size_variance = 1, | ||
| }, | ||
| }, | ||
| .parentBiomes = .{ | ||
| .{ | ||
| .id = "cubyz:desert_shrubland/base", | ||
|
Contributor
There was a problem hiding this comment. Please update these to the new names, they are causing errors. |
||
| .chance = 25, | ||
| }, | ||
| }, | ||
| } | ||
|
Contributor
There was a problem hiding this comment. I think this could be less common. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| .{ | ||
| .minHeightLimit = 7, | ||
| .minHeight = 22, | ||
| .maxHeight = 40, | ||
| .maxHeightLimit = 50, | ||
| .minRadius = 50, | ||
| .maxRadius = 70, | ||
| .hills = 20, | ||
| .keepOriginalTerrain = 1, | ||
| .structures = .{ | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:tree/baobab/shrub", | ||
| .placeMode = .degradable, | ||
| .chance = 0.30, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:tree/baobab/small", | ||
| .placeMode = .degradable, | ||
| .chance = 0.2, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:tree/baobab/young", | ||
| .placeMode = .degradable, | ||
| .chance = 0.05, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:tree/baobab/grandidieri", | ||
| .placeMode = .degradable, | ||
| .chance = 0.01, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:cactus/saguaro", | ||
| .placeMode = .degradable, | ||
| .chance = 0.01, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:cactus/young", | ||
| .placeMode = .degradable, | ||
| .chance = 0.003, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:ground_patch", | ||
| .block = "cubyz:dirt", | ||
| .chance = 0.28, | ||
| .width = 5, | ||
| .variation = 6, | ||
| .depth = 3, | ||
| .smoothness = 0.1, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:flower_patch", | ||
| .blocks = .{"cubyz:tussock"}, | ||
| .chance = 0.28, | ||
| .width = 4, | ||
| .variation = 4, | ||
| .density = 0.2, | ||
| .priority = 0.1, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:simple_vegetation", | ||
| .chance = 0.14, | ||
| .block = "cubyz:ocotillo", | ||
| .height = 1, | ||
| .height_variation = 0, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:flower_patch", | ||
| .blocks = .{"cubyz:ocotillo"}, | ||
| .chance = 0.03, | ||
| .width = 4, | ||
| .variation = 4, | ||
| .density = 0.2, | ||
| .priority = 0.1, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:simple_vegetation", | ||
| .chance = 0.07, | ||
| .block = "cubyz:dry_grass_vegetation", | ||
| .height = 1, | ||
| .height_variation = 0, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:ground_patch", | ||
| .block = "cubyz:pebbles:cubyz:sand", | ||
| .chance = 0.05, | ||
| .width = 1, | ||
| .variation = 1, | ||
| .depth = 1, | ||
| .smoothness = 0.6, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:boulder", | ||
| .chance = 0.03, | ||
| .block = "cubyz:slate/cobble", | ||
| .size = 3, | ||
| .size_variance = 1, | ||
| }, | ||
| }, | ||
| .parentBiomes = .{ | ||
| .{ | ||
| .id = "cubyz:desert_shrubland/base", | ||
| .chance = 30, | ||
| }, | ||
| }, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| .{ | ||
| .minHeightLimit = 7, | ||
| .minHeight = 30, | ||
| .maxHeight = 60, | ||
| .maxHeightLimit = 70, | ||
| .minRadius = 70, | ||
| .maxRadius = 90, | ||
| .hills = 30, | ||
| .structures = .{ | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:tree/baobab/shrub", | ||
| .placeMode = .degradable, | ||
| .chance = 0.36, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:cactus/saguaro", | ||
| .placeMode = .degradable, | ||
| .chance = 0.01, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:sbb", | ||
| .structure = "cubyz:cactus/young", | ||
| .placeMode = .degradable, | ||
| .chance = 0.003, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:ground_patch", | ||
| .block = "cubyz:dirt", | ||
| .chance = 0.24, | ||
| .width = 5, | ||
| .variation = 6, | ||
| .depth = 3, | ||
| .smoothness = 0.2, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:ground_patch", | ||
| .block = "cubyz:pebbles:cubyz:sand", | ||
| .chance = 0.17, | ||
| .width = 1, | ||
| .variation = 1, | ||
| .depth = 2, | ||
| .smoothness = 0.1, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:flower_patch", | ||
| .blocks = .{"cubyz:tussock"}, | ||
| .chance = 0.08, | ||
| .width = 4, | ||
| .variation = 4, | ||
| .density = 0.2, | ||
| .priority = 0.1, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:simple_vegetation", | ||
| .chance = 0.05, | ||
| .block = "cubyz:ocotillo", | ||
| .height = 1, | ||
| .height_variation = 0, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:flower_patch", | ||
| .blocks = .{"cubyz:ocotillo"}, | ||
| .chance = 0.02, | ||
| .width = 4, | ||
| .variation = 4, | ||
| .density = 0.2, | ||
| .priority = 0.1, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:simple_vegetation", | ||
| .chance = 0.05, | ||
| .block = "cubyz:dry_grass_vegetation", | ||
| .height = 1, | ||
| .height_variation = 0, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:boulder", | ||
| .chance = 0.03, | ||
| .block = "cubyz:slate/cobble", | ||
| .size = 3, | ||
| .size_variance = 1, | ||
| }, | ||
| }, | ||
| .parentBiomes = .{ | ||
| .{ | ||
| .id = "cubyz:desert_shrubland/base", | ||
| .chance = 50, | ||
| }, | ||
| }, | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this in to the desert folder (
desert/shrubland/base)(and rename the subbiome as i said previously)
The biome creates a lot of these pools, causing all the plants to be underwater. You can instead use subbiomes like in the oasis or swampy biomes to prevent this. I also think there could be less water generally.
Actually, now that I'm looking at it, is this even intentional? Looks like the hills subbiome is causing it.