Conversation
PeterN
force-pushed
the
soxr
branch
2 times, most recently
from
December 7, 2024 11:44
673fec9 to
147d663
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
PeterN
force-pushed
the
soxr
branch
3 times, most recently
from
September 15, 2025 23:31
ee3054a to
ab2e1ee
Compare
indonesian: 121 changes by q1t0
swedish: 6 changes by joeax910 maori (new zealand): 7 changes by Kyle-McDangersword
Bumps the actions group with 4 updates in the / directory: [actions/upload-artifact](https://github.com/actions/upload-artifact), [actions/download-artifact](https://github.com/actions/download-artifact), [Apple-Actions/import-codesign-certs](https://github.com/apple-actions/import-codesign-certs) and [microsoft/microsoft-store-apppublisher](https://github.com/microsoft/microsoft-store-apppublisher). Updates `actions/upload-artifact` from 6 to 7 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v6...v7) Updates `actions/download-artifact` from 6 to 8 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v6...v8) Updates `Apple-Actions/import-codesign-certs` from 6 to 7 - [Release notes](https://github.com/apple-actions/import-codesign-certs/releases) - [Commits](Apple-Actions/import-codesign-certs@v6...v7) Updates `microsoft/microsoft-store-apppublisher` from 1.1 to 1.3 - [Release notes](https://github.com/microsoft/microsoft-store-apppublisher/releases) - [Commits](microsoft/microsoft-store-apppublisher@v1.1...v1.3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: actions/download-artifact dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: Apple-Actions/import-codesign-certs dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: microsoft/microsoft-store-apppublisher dependency-version: '1.3' dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com>
HasFoundationNW and HasFoundationNE were used in a similar way in DrawFoundation and DrawTile_Station. Factor this usage out into its own function GetFoundationSpriteBlock, which allows to make HasFoundationNW and HasFoundationNE static.
The logic in both of them is simillar and they only differ in constant values. Both of them are only used once so when merged the reason for it not to be inlined is back. It is easier to document one function than two.
GRF ID needs to be reversed when coming from a uint32_t.
Refactor company name generation to remove gotos, and check that names are unique by string instead of just the seed parameter, which could result in the same name.
…er (OpenTTD#15494) The condition is now "driving backwards at reduced speed". If a train is able to run at full speed when driving backwards then there is no need to perform manoeuvres to turn around
This allows widgets to return a different size depending on the size that would be used, allowing for more dynamic sizing.
Uses a dynamic widget to switch the buttons between 1 and 2 column layout depending on height, and improves use of space.
) The most common usage for this function is to convert a DWord from NewGRF into a label. Now the rare cases, sending over the network and script interaction, requires a std::byteswap. This reverts commit 9140a7a
…nTTD#15921) Achieves what f9e6b8b aimed to do, as a read error will replace the current set id, but as it is only replaced at the end, chaining to the same set id works correctly. Also reduces cognitive complexity.
english (au): 1 change by krysclarke english (us): 1 change by 2TallTyler greek: 1 change by gh658804 hungarian: 7 changes by vargaviktor russian: 1 change by Ln-Wolf finnish: 1 change by hpiirai portuguese: 1 change by jcteotonio portuguese (brazilian): 1 change by pasantoro polish: 1 change by pAter-exe
If not present the existing but bad quality linear conversion can still be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If not present the existing bad quality linear conversion can still be used.
Motivation / Problem
Description
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.