fix: check y == 0 before abs(x) in SD59x18 powu to handle MIN_SD59x18#279
Merged
PaulRBerg merged 3 commits intoMay 30, 2026
Merged
Conversation
- add regression coverage for MIN_SD59x18 with zero exponent - qualify powu requirements for the zero-exponent path
Owner
|
Good catch. Thanks @BhariGowda. I've fixed the NatSpec and the formatting, and updated the tests. Merging. |
Owner
|
The fix is available in v4.1.2, already shipped to npm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
powu(MIN_SD59x18, 0)currently reverts instead of returningUNIT.abs()is called before they == 0short-circuit check, andabs(MIN_SD59x18)always reverts. Mathematically,
x^0 = 1for all x includingMIN_SD59x18.Compare with
pow()which correctly handlesy == 0before touchingx.Fix
Move the
y == 0guard before theabs(x)call: