Skip to content

Tippy warnings suggestions#3064

Merged
ngallegos merged 4 commits into
add-tippyfrom
tippy-warnings-suggestions
Jul 14, 2026
Merged

Tippy warnings suggestions#3064
ngallegos merged 4 commits into
add-tippyfrom
tippy-warnings-suggestions

Conversation

@ngallegos

Copy link
Copy Markdown
Contributor

Suggestion for:

This adds a global tippy stub so future tests don't need to stub it and removes test-specific stubs that throw a dupilcate warning.

Reviewer Checklist

  • Components are broken down into sensible and maintainable sub-components.
  • Styles are scoped to the component using it. If multiple components need to share CSS, then a .css file is created containing the shared CSS and imported into component scoped style sections.
  • Naming is consistent with existing code, and adequately describes the component or function being introduced
  • Only functions utilizing Vue state or lifecycle hooks are named as composables (i.e. starting with 'use');
  • No module-level state is being introduced. If so, request the PR author to move the state to the corresponding Pinia store.

@ngallegos ngallegos merged commit 316d91c into add-tippy Jul 14, 2026
5 checks passed
@ngallegos ngallegos deleted the tippy-warnings-suggestions branch July 14, 2026 20:17
tamararivera added a commit that referenced this pull request Jul 15, 2026
* Add the stub for tippy to the Throughputreport tests

* Tippy warnings suggestions (#3064)

* Remove tippy directive warnings globally

* Missed some duplicate tippy stubs

* Revert "Add the stub for tippy to the Throughputreport tests"

This reverts commit 58beaa2.

* Linter doesn't like the comment

---------

Co-authored-by: Nick Gallegos <nick.gallegos@particular.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants