ci: harden release asset publishing - #1920
Merged
Merged
Conversation
Problem: --deb only warned when cargo-deb or dpkg-deb was absent, so a build could pass while producing an incomplete set of .deb files, and the release asset staging failed later on the missing package. Solution: require both packagers before packaging and exit non-zero when one is missing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Problem: the manual backfill looked up build runs on master only, so a tag cut from a release branch never resolved its Linux and Windows runs. Solution: drop the branch filter; push runs exist only on master and release branches, and the head SHA already selects the release commit. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
0 findings in 2m 36s for $0.05 between |
Build Artifacts🐧 Linux
From workflow run 🪟 Windows
From workflow run |
volsa
approved these changes
Sep 15, 2026
ghaith
added a commit
that referenced
this pull request
Sep 15, 2026
Backport of #1920. Problem: a Linux build passes even when cargo-deb is missing, so the deb artifacts lack the plc-compiler package and the release asset staging fails on the missing file. The manual backfill cannot recover a release cut from a release branch because it only searches runs on master. Solution: fail deb packaging when a packager is missing, and look up backfill runs by head SHA without a branch filter. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: a Linux build passes even when cargo-deb is missing, so the deb artifacts lack the plc-compiler package and the release asset staging fails on the missing file. The manual backfill cannot recover a release cut from a release branch because it only searches runs on master.
Solution: fail deb packaging when a packager is missing, and look up backfill runs by head SHA without a branch filter.
🤖 Generated with Claude Code