Skip to content

chore: pin data-connect to data-connect#89's merge commit - #95

Merged
tnunamak merged 1 commit into
mainfrom
chore/normalize-data-connect-pin
Sep 10, 2026
Merged

chore: pin data-connect to data-connect#89's merge commit#95
tnunamak merged 1 commit into
mainfrom
chore/normalize-data-connect-pin

Conversation

@tnunamak

Copy link
Copy Markdown
Contributor

Every data-connect pull request that touches a guarded path currently fails Check data-connectors' recorded pin, including ones that change nothing under the vendored tree. The recorded pin is 27fe8086d on branch chore/revendor-connectors-92. consumer-drift-signal.yml requires the pinned commit to exist in its own checkout (git cat-file -e) before it diffs $GUARDED_PATHS against it. actions/checkout on a pull_request fetches only refs/pull/N/merge, which is full history of that ref and not of other branches. Once #89 was rebased, 27fe8086d was reachable from no ref at all, so the lookup failed before any comparison ran. consumer_pin_required is true, so that failure is fail-closed by design.

data-connect#89 merged as 1577a34e5, putting the re-vendored connector sources on main. This points the pin there and restores branch to main.

Ran locally against a clean checkout at the candidate pin:

Job Result
(a) collector-definitions OK — snapshot matches collector-registry.ts
(b) connector-sources OK — 30 files across 6 connectors byte-identical
(d) reference-contract OK — all three stand-in modules match pinned pdpp source
(e) collector-packaging-manifest OK — tsconfig.build.json compiles exactly the 6 registry connectors

Job (b) is the only one that discriminates between the candidate SHAs. It fails at the pre-#89 main head f28312c2a with four byte mismatches — claude_code/index.ts, claude_code/types.ts, codex/index.ts, codex/types.ts — and passes at 1577a34e5, because #89 is what put those vendored sources on main. Jobs (a) and (e) pass at both heads, so they confirm this change breaks nothing rather than proving it necessary; (d) reads only the pdpp pin, which this change does not touch.

Also verified that data-connect#64, the other open pull request hitting this check, passes at the new pin: rebuilding its merge ref against the current base makes 1577a34e5 reachable, and the $GUARDED_PATHS diff is empty.

Not verified: job (c) tarball-digests could not run here — npm refused the git-protocol fetch of @opendatalabs/data-connectors-tools (EALLOWGIT). That is an environment restriction, not a drift result, and job (c) does not read the connector-source paths this change affects. It is unverified rather than passing.

Assisted-by: AI

The data-connect pin named 27fe8086d on branch chore/revendor-connectors-92, an
unmerged branch. data-connect's consumer-drift-signal workflow requires the pinned
commit to exist in its own checkout before it can diff guarded paths against it, and
a pull-request merge ref cannot reach a commit that lives only on an unrelated
branch. Once that branch was rebased, 27fe8086d became reachable from no ref at all,
so the lookup failed for every data-connect pull request touching a guarded path,
including ones that change nothing under the vendored tree.

data-connect#89 has now merged as 1577a34e5, putting the re-vendored connector
sources on main. Pointing the pin at that merge commit restores a reachable,
merged-main SHA and clears the failure for both repositories.

Verified locally at the new pin: drift jobs (a) collector-definitions, (b)
connector-sources (30 files across 6 connectors byte-identical), (d)
reference-contract and (e) collector-packaging-manifest all pass. Job (c)
tarball-digests could not run in this environment because npm refused a git-protocol
dependency fetch; it is unverified here rather than passing.

Assisted-by: AI
Signed-off-by: Tim Nunamaker <tnunamak@gmail.com>
@github-actions

Copy link
Copy Markdown

Schema Health Check — All Clear

All 73 scopes have consistent local schema files.

@tnunamak
tnunamak merged commit 8bac234 into main Sep 10, 2026
19 checks passed
@tnunamak
tnunamak deleted the chore/normalize-data-connect-pin branch September 10, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant