chore: pin data-connect to data-connect#89's merge commit - #95
Merged
Conversation
The data-connect pin named 27fe8086d on branch chore/revendor-connectors-92, an unmerged branch. data-connect's consumer-drift-signal workflow requires the pinned commit to exist in its own checkout before it can diff guarded paths against it, and a pull-request merge ref cannot reach a commit that lives only on an unrelated branch. Once that branch was rebased, 27fe8086d became reachable from no ref at all, so the lookup failed for every data-connect pull request touching a guarded path, including ones that change nothing under the vendored tree. data-connect#89 has now merged as 1577a34e5, putting the re-vendored connector sources on main. Pointing the pin at that merge commit restores a reachable, merged-main SHA and clears the failure for both repositories. Verified locally at the new pin: drift jobs (a) collector-definitions, (b) connector-sources (30 files across 6 connectors byte-identical), (d) reference-contract and (e) collector-packaging-manifest all pass. Job (c) tarball-digests could not run in this environment because npm refused a git-protocol dependency fetch; it is unverified here rather than passing. Assisted-by: AI Signed-off-by: Tim Nunamaker <tnunamak@gmail.com>
Schema Health Check — All ClearAll 73 scopes have consistent local schema files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every data-connect pull request that touches a guarded path currently fails
Check data-connectors' recorded pin, including ones that change nothing under the vendored tree. The recorded pin is27fe8086don branchchore/revendor-connectors-92.consumer-drift-signal.ymlrequires the pinned commit to exist in its own checkout (git cat-file -e) before it diffs$GUARDED_PATHSagainst it.actions/checkouton apull_requestfetches onlyrefs/pull/N/merge, which is full history of that ref and not of other branches. Once #89 was rebased,27fe8086dwas reachable from no ref at all, so the lookup failed before any comparison ran.consumer_pin_requiredistrue, so that failure is fail-closed by design.data-connect#89 merged as
1577a34e5, putting the re-vendored connector sources on main. This points the pin there and restoresbranchtomain.Ran locally against a clean checkout at the candidate pin:
collector-registry.tstsconfig.build.jsoncompiles exactly the 6 registry connectorsJob (b) is the only one that discriminates between the candidate SHAs. It fails at the pre-#89 main head
f28312c2awith four byte mismatches —claude_code/index.ts,claude_code/types.ts,codex/index.ts,codex/types.ts— and passes at1577a34e5, because #89 is what put those vendored sources on main. Jobs (a) and (e) pass at both heads, so they confirm this change breaks nothing rather than proving it necessary; (d) reads only the pdpp pin, which this change does not touch.Also verified that data-connect#64, the other open pull request hitting this check, passes at the new pin: rebuilding its merge ref against the current base makes
1577a34e5reachable, and the$GUARDED_PATHSdiff is empty.Not verified: job (c) tarball-digests could not run here — npm refused the git-protocol fetch of
@opendatalabs/data-connectors-tools(EALLOWGIT). That is an environment restriction, not a drift result, and job (c) does not read the connector-source paths this change affects. It is unverified rather than passing.Assisted-by: AI