Add Mannequin Hooks For PVE Use#562
Conversation
private object CanMannequinChangePose(Mannequin mannequin, BasePlayer player) private object CanMannequinSwap(Mannequin mannequin, BasePlayer player)
|
Why do you use Can for On object hooks? What's the point of creating rules for hooks if they are not followed? And it’s preferable to place verbs at the end of hook names, so that if necessary a hook can be added after execution. |
|
When I submitted the hooks I went off what it said on oxidemod docs. The purpose of the hooks is to block. |
|
Very strange. After all, they do write that Can hooks are used in places where a bool type is expected. Here’s an example of correct Can hooks:
Here’s incorrect ones:
On hooks expect null to CONTINUE vanilla code, or ANY non-null value of ANY type to BLOCK vanilla code. |
private object CanMannequinChangePose(Mannequin mannequin, BasePlayer player)
private object CanMannequinSwap(Mannequin mannequin, BasePlayer player)