frontend: Add NewLabelStatement and LabelType - #1064
Merged
Conversation
benjaminkasper99
force-pushed
the
feature/newlabel-statement
branch
from
August 24, 2026 11:52
e8e6650 to
f84c317
Compare
benjaminkasper99
marked this pull request as ready for review
August 24, 2026 12:33
flofriday
reviewed
Aug 25, 2026
flofriday
left a comment
flofriday
left a comment
Contributor
There was a problem hiding this comment.
Overall quite good, some issues need to be fixed but shouldn't be too much.
In the future, could you maybe turn off the automatic whole-file-formatting in your editor? The reformats were all fine so I left them now, but for one it makes reviewing harder because it's not initially clear why you even touched that code and secondly it clutters the git history.
I know it's a shame that our checkstyle rules aren't strict enough to not have catched them in the first place.
Jozott00
reviewed
Aug 26, 2026
benjaminkasper99
force-pushed
the
feature/newlabel-statement
branch
from
August 28, 2026 06:10
e69dca0 to
15abc3e
Compare
benjaminkasper99
force-pushed
the
feature/newlabel-statement
branch
2 times, most recently
from
August 31, 2026 07:54
e82676f to
ca1506d
Compare
benjaminkasper99
force-pushed
the
feature/newlabel-statement
branch
from
August 31, 2026 08:15
ca1506d to
e9c236f
Compare
flofriday
enabled auto-merge
August 31, 2026 09:09
flofriday
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
Solution 1proposed in the comments of #148.The introduced
NewLabelStatementis lowered to the existing VIAMNewLabelNode, which is used by the LCB to emit assembly labels when expanding instruction sequences. This allows us to finally remove theHardcodeLGALabelPass.Note that the spec changes of this PR break the
rv32imassembler and linker in the sense that they produce incorrect binaries. Because of this I disabled two CodeEmitter tests. The issue will be fixed and the tests re-enabled with the follow-up PR #1071.