fix(cli): forward solver config to all model benchmarks and improve error resilience - #77
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
Original prompt from Jason
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Community fix from @warun7 (authored commit preserved, brought in from
warun7:benchmark-harness:fix/cli-solver-config-and-resiliencebecause the repo's interaction limits blocked a direct PR):--solver-configis now honored forgpqa_diamond,mmlu_pro,mmmu_pro_vision, andifstruct, the progress bar is always stopped on failure, and non-numeric values for numeric flags fail fast.What changed?
buildBenchmarkConfigno longer hand-builds configs forgpqa_diamond,mmlu_pro,mmmu_pro_vision,ifstruct,tau_bench_verified_airline,tau3_bench_banking,terminal_bench. All fall through tobuildSchemaValidatedConfig, which mergespanelConfigkeys (providerOnly,maxTokens,timeoutMs,sort, ...) and validates againstBenchmarkRunConfigSchema.buildSchemaValidatedConfiggains an optionalimageDetailpassthrough formmmu_pro_vision.runBenchmarkByIdcall inmainis wrapped intry ... finallysobar.stop()runs (only if the bar was started) when the run throws, restoring the terminal cursor.num()inparseArgsthrowsTypeError("<flag> must be a valid number, got: <raw>")whenNumber(raw)is not finite, instead of returningNaNinto--concurrency,--limit,--start,--end,--epochs.src/cli/index.test.tsfor all three behaviors.Why?
Reported on Discord by warun7. On
main, the four model benchmarks above parsed--solver-configbut never used it, so provider pinning and token/timeout limits silently did nothing. A crash mid-run left the terminal cursor hidden.--concurrency abcproducedNaNand undefined downstream behavior.Searched existing PRs (open, closed, draft) for "solver-config", CLI, and
src/cli/index.ts; none matched.How to test
Expected: request goes to the pinned provider with
max_tokens: 2048(onmainit did not).Expected: exits with
--concurrency must be a valid number, got: abc.Expected:
Unknown gpqa_diamond solver-config option(s): unknownOption(previously silently ignored).Locally on this branch:
bun run format:check,bun run check,bun run typecheck,bun test(1409 pass),bun run buildall succeed.Benchmark impact
No change to solvers, scorers, prompts, or datasets. Runs of the four affected benchmarks that passed a
--solver-configwill now actually apply it, so results from such invocations are not comparable to pre-fix runs where the config was dropped. Runs without--solver-configare unaffected.Reviewer focus
--solver-configkeys now throw forgpqa_diamond,mmlu_pro,mmmu_pro_vision,ifstructinstead of being ignored. This matches how the other model benchmarks already behaved.imageDetailis passed only formmmu_pro_vision, keeping other configs schema-identical to before.Checklist
Link to Devin session: https://openrouter.devinenterprise.com/sessions/e348d039d09045f3a3cc9fc485bf2cda
Open in Devin Desktop: https://openrouter.devinenterprise.com/desktop/session/e348d039d09045f3a3cc9fc485bf2cda?variant=devin
Requested by: @jasoncrabtree-or
Note
Devin errored when opening this Pull Request as jasoncrabtree-or.
As a fallback, Devin opened this PR as itself.