fix summary - #1077
Closed
Belfagor2005 wants to merge 7 commits into
Closed
Conversation
Il codice usava la funzione cmp() di Python 2 che non esiste in Python 3 Fix: Sostituito con functools.cmp_to_key() oppure con funzioni key per sort() '<' not supported between instances of 'str' and 'float' Problema: La funzione byDateFunc() restituiva a volte float (timestamp) e a volte string (fallback su nome) Fix: Usato una tupla (priority, value) per garantire ordinamento coerente: (0, timestamp) per elementi con data valida (1, nome) per elementi senza data
Contributor
|
Where is cmp() ? What is the actually fix? Seems a copy/pase from OE-A (but I could be wrong). |
Contributor
Author
|
you have right.. |
Contributor
Author
|
for me work.. thank's |
Member
|
@Hains This is still open, is this still relevant? And if so, can it be merged (squashed to remove those merge commits)? |
Change poster visibility in imdb/src/plugin.py for the TitleReviewsRefine branch: replace self["poster"].show() with self["poster"].hide(). Ensures the poster is hidden when extra/details/cast labels are displayed, keeping the UI consistent.
Member
|
This PR is becoming a right mess, and now you sneak an IMDB change in here? |
Contributor
Author
|
Not secretly, I had no idea it was open on another PR. |
Member
|
Ah, ok. Need to close this, can't do partial merges in Github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code used the Python 2 cmp() function, which doesn't exist in Python 3.
Fix: Replaced with functools.cmp_to_key() or key functions for sort().
'<' not supported between instances of 'str' and 'float'.
Problem: The byDateFunc() function sometimes returned a float (timestamp) and sometimes a string (fallback to name).
Fix: Used a tuple (priority, value) to ensure consistent sorting:
(0, timestamp) for elements with a valid date.
(1, name) for elements without a date.