perf(anime): decouple kernel I/O with Condvar mailbox, FIFO control queue, zero-copy D-Bus proxy, and frame pre-computation

asusctl/examples/anime-diag-png.rs

@@ -27,7 +27,7 @@ fn main() -> Result<(), Box<dyn Error>> {
 
     let anime_type = get_anime_type();
 
-    proxy.write(matrix.into_data_buffer(anime_type)?).unwrap();
+    proxy.write(&matrix.into_data_buffer(anime_type)?).unwrap();
 
     Ok(())
 }

asusctl/examples/anime-diag.rs

@@ -30,9 +30,16 @@ fn main() {
         }
 
         let anime_type = get_anime_type();
-        proxy
-            .write(matrix.into_data_buffer(anime_type).unwrap())
-            .unwrap();
+        match matrix.into_data_buffer(anime_type) {
+            Ok(buf) => {
+                if let Err(e) = proxy.write(&buf) {
+                    eprintln!("Failed to write matrix frame to D-Bus: {e}");
+                }
+            }
+            Err(e) => {
+                eprintln!("Failed to convert matrix into data buffer: {e}");
+            }
+        }
         sleep(Duration::from_millis(300));
     }
 }

asusctl/examples/anime-gif.rs

@@ -35,7 +35,7 @@ fn main() {
         for action in seq.iter() {
             if let ActionData::Animation(frames) = action {
                 for frame in frames.frames() {
-                    proxy.write(frame.frame().clone()).unwrap();
+                    proxy.write(frame.frame()).unwrap();
                     sleep(frame.delay());
                 }
             }

asusctl/examples/anime-grid.rs

@@ -46,5 +46,5 @@ fn main() {
 
     let matrix = <AnimeDataBuffer>::try_from(matrix).unwrap();
 
-    proxy.write(matrix).unwrap();
+    proxy.write(&matrix).unwrap();
 }

asusctl/examples/anime-led-scan.rs

@@ -90,14 +90,16 @@ fn write_single_led(
     if index < data.len() {
         data[index] = brightness;
     }
-    if let Err(e) = proxy.write(buffer) {
+    if let Err(e) = proxy.write(&buffer) {
         eprintln!("Error writing to device: {}", e);
     }
 }
 
 fn clear_display(proxy: &AnimeProxyBlocking, anime_type: AnimeType) {
     let buffer = AnimeDataBuffer::new(anime_type);
-    let _ = proxy.write(buffer);
+    if let Err(e) = proxy.write(&buffer) {
+        eprintln!("Error writing to device: {}", e);
+    }
 }
 
 fn fill_display(proxy: &AnimeProxyBlocking, anime_type: AnimeType, brightness: u8) {
@@ -106,7 +108,7 @@ fn fill_display(proxy: &AnimeProxyBlocking, anime_type: AnimeType, brightness: u
     for byte in data.iter_mut() {
         *byte = brightness;
     }
-    if let Err(e) = proxy.write(buffer) {
+    if let Err(e) = proxy.write(&buffer) {
         eprintln!("Error writing to device: {}", e);
     }
 }
@@ -124,7 +126,7 @@ fn fill_range(
     for i in start..=end.min(data.len().saturating_sub(1)) {
         data[i] = brightness;
     }
-    if let Err(e) = proxy.write(buffer) {
+    if let Err(e) = proxy.write(&buffer) {
         eprintln!("Error writing to device: {}", e);
     }
 }

asusctl/examples/anime-outline.rs

@@ -129,5 +129,5 @@ fn main() {
     matrix.data_mut()[1244] = 100; // end
     println!("{:?}", matrix);
 
-    proxy.write(matrix).unwrap();
+    proxy.write(&matrix).unwrap();
 }

asusctl/examples/anime-png.rs

@@ -33,7 +33,7 @@ fn main() -> Result<(), Box<dyn Error>> {
         anime_type,
     )?;
 
-    proxy.write(<AnimeDataBuffer>::try_from(&matrix)?).unwrap();
+    proxy.write(&<AnimeDataBuffer>::try_from(&matrix)?).unwrap();
 
     Ok(())
 }

asusctl/examples/anime-spinning.rs

@@ -43,7 +43,7 @@ fn main() -> Result<(), Box<dyn Error>> {
         }
         matrix.update();
 
-        proxy.write(<AnimeDataBuffer>::try_from(&matrix)?).unwrap();
+        proxy.write(&<AnimeDataBuffer>::try_from(&matrix)?).unwrap();
         sleep(Duration::from_micros(500));
     }
 }

asusctl/src/main.rs

@@ -370,7 +370,7 @@ fn handle_anime(cmd: &AnimeCommand) -> Result<(), Box<dyn std::error::Error>> {
         if cmd.clear {
             let data = vec![255u8; anime_type.data_length()];
             let tmp = AnimeDataBuffer::from_vec(anime_type, data)?;
-            proxy.write(tmp)?;
+            proxy.write(&tmp)?;
         }
 
         if let Some(action) = cmd.command.as_ref() {
@@ -393,7 +393,7 @@ fn handle_anime(cmd: &AnimeCommand) -> Result<(), Box<dyn std::error::Error>> {
                         anime_type,
                     )?;
 
-                    proxy.write(<AnimeDataBuffer>::try_from(&matrix)?)?;
+                    proxy.write(&<AnimeDataBuffer>::try_from(&matrix)?)?;
                 }
                 AnimeActions::PixelImage(image) => {
                     if image.path.is_empty() {
@@ -407,7 +407,7 @@ fn handle_anime(cmd: &AnimeCommand) -> Result<(), Box<dyn std::error::Error>> {
                     let matrix =
                         AnimeDiagonal::from_png(Path::new(&image.path), image.bright, anime_type)?;
 
-                    proxy.write(matrix.into_data_buffer(anime_type)?)?;
+                    proxy.write(&matrix.into_data_buffer(anime_type)?)?;
                 }
                 AnimeActions::Gif(gif) => {
                     if gif.path.is_empty() {
@@ -431,7 +431,7 @@ fn handle_anime(cmd: &AnimeCommand) -> Result<(), Box<dyn std::error::Error>> {
                     let mut loops = gif.loops as i32;
                     loop {
                         for frame in matrix.frames() {
-                            proxy.write(frame.frame().clone())?;
+                            proxy.write(frame.frame())?;
                             sleep(frame.delay());
                         }
                         if loops >= 0 {
@@ -461,7 +461,7 @@ fn handle_anime(cmd: &AnimeCommand) -> Result<(), Box<dyn std::error::Error>> {
                     let mut loops = gif.loops as i32;
                     loop {
                         for frame in matrix.frames() {
-                            proxy.write(frame.frame().clone())?;
+                            proxy.write(frame.frame())?;
                             sleep(frame.delay());
                         }
                         if loops >= 0 {

asusd-user/src/ctrl_anime.rs

@@ -96,13 +96,13 @@ impl CtrlAnimeInner<'static> {
                             return Ok(true); // Do safe exit
                         }
                         self.client
-                            .write(output)
+                            .write(&output)
                             .map_err(|e| AnimeError::Dbus(format!("{}", e)))
                             .map(|_| false)
                     });
                 }
                 ActionData::Image(image) => {
-                    self.client.write(image.as_ref().clone()).ok();
+                    self.client.write(image.as_ref()).ok();
                 }
                 ActionData::Pause(duration) => {
                     let start = Instant::now();