input: joystick: adc-joystick: guard against NULL active_scan_mask - #17
Open
wormuz wants to merge 1 commit into
Open
input: joystick: adc-joystick: guard against NULL active_scan_mask#17wormuz wants to merge 1 commit into
wormuz wants to merge 1 commit into
Conversation
adc_joystick_get_chan_offsets() dereferences indio_dev->active_scan_mask without checking it. The mask is only allocated once the IIO buffer is enabled; when the joystick probes against a driver whose buffer setup has not run yet (or was torn down), the pointer is NULL and test_bit() faults. Observed as a probe-time oops on JZ4770 (RG350P handheld) with the ingenic-adc driver, where adc-joystick can bind before the IIO buffer exists. Treat a NULL mask the same as a channel without a valid scan index: mark the offset as -1 and fall back to per-channel reads. Signed-off-by: wormuz <3341798+wormuz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adc_joystick_get_chan_offsets() dereferences indio_dev->active_scan_mask without checking it. The mask is only allocated once the IIO buffer is enabled; when adc-joystick binds before the buffer setup has run, the pointer is NULL and test_bit() faults.
Observed as a probe-time oops on an RG350P handheld (JZ4770, ingenic-adc).