Add rollover metadata containing all available keys#1899
Merged
kayjoosten merged 3 commits intoOpenConext:mainfrom Mar 27, 2026
Merged
Add rollover metadata containing all available keys#1899kayjoosten merged 3 commits intoOpenConext:mainfrom
kayjoosten merged 3 commits intoOpenConext:mainfrom
Conversation
07e9c6c to
38b72e8
Compare
|
Dit lijkt me zeer gewenst. Wij moeten volgend jaar op productie ook rollover'en en alles wat dit proces soepeler kan laten verlopen is mooi meegenomen. |
Contributor
|
@kayjoosten Can you:
|
39cf222 to
fc47521
Compare
johanib
requested changes
Mar 24, 2026
src/OpenConext/EngineBlockFunctionalTestingBundle/Features/Metadata.feature
Show resolved
Hide resolved
Contributor
|
Request: GET /authentication/sp/metadata
So when you request key:rollover, the document is signed with the rollover private key. When you request the default, it's signed with the default private key. |
- Fix broken unit tests in decorator classes after array change - Add buildAll() unit test to KeyPairFactoryTest - Add Behat scenarios verifying all keys appear in default metadata - Update FrontPage test to expect rollover key links - Add CI and dev env parameters with rollover key for testing - Remove unused X509Certificate import from EngineBlockServiceProvider
fc47521 to
783497e
Compare
johanib
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We sign our AuthnRequests to our IdPs, so we need to have metadata containing both the current and the rollover-certificate.
With this patch, the default metadata (keyslug=default or no keyslug) will contain all the configured keys.