Repository navigation
Describe the changes in the AI review fix PR - #19
Merged
Merged
Conversation
The fix PR only pointed back at the reviewed PR and listed commit subjects, so a reviewer had to go to the parent PR to learn what the fixes did. Its body now has a "What changed" section listing each fix commit with the fixes its message records (file, line, problem and fix), without the harness trailers. Comment openers are escaped as in the review summary, and the body is capped under GitHub's limit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The fix PR opened by the AI review (
ai_review_publish.sh) now has a What changed section. It lists each fix commit's subject and the fixes recorded in that commit's message (path:line - problem and fix, from the reviewers'issues_fixed). Before, the body was one line pointing back to the reviewed PR plus a list of commit subjects.Why it changed
A reviewer of the fix PR had to go to the parent PR's review comment to find out what the fixes did. The fix PR should describe its own changes.
Testing strategy
Extended
test_publish_opens_a_fix_pr_by_defaultto check the PR body: the heading, the commit subject, the fix line, that<!--is escaped and that theAI-Review-Bottrailers are left out.python3 -m unittest discover -s testspasses (89 tests) and ruff is clean.Review notes
apply_fixes's secret check and are scanned by the Malicious Code Scan. So the body adds no new unchecked agent text.<!--is escaped the same way as in the review summary, and the body is cut at 60,000 characters to stay under GitHub's limit.🤖 Generated with Claude Code