Repository navigation
[Java][Spring] useRecords: no @NotNull on records without bean validation - #25265
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#25131 removed
@NotNulland its import from classes whenuseBeanValidationis off. The record template from #25200 still printed the annotation, so withuseRecordsanduseBeanValidation=falsea record with a required property stopped compiling. Records now follow classes there. With bean validation on, oruseRecordsoff, the output is unchanged.@cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog @martin-mfg @KannaKim
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Fixes the Java Spring record template emitting
@NotNullon required fields whenuseBeanValidationis off, which produced records that did not compile because the annotation import was missing. Records now match the classes behavior and emit no bean validation annotations when validation is disabled. Output is unchanged when bean validation is on oruseRecordsis off.Adds regression tests covering record generation with and without bean validation.
Written for commit db7cd1e. Summary will update on new commits.