Repository navigation
[python] Support "default" responses in python client - #24309
Merged
wing328 merged 4 commits intoJul 18, 2026
Merged
Conversation
Update examples
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 20 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
EraYaN
force-pushed
the
python-support-default-responses
branch
from
July 15, 2026 08:30
d171522 to
b670e10
Compare
EraYaN
force-pushed
the
python-support-default-responses
branch
from
July 15, 2026 08:32
b670e10 to
edf2f14
Compare
wing328
reviewed
Jul 15, 2026
Contributor
Author
|
I have added a small comment, it's essentially an inverse condition of the previous two statements |
EraYaN
force-pushed
the
python-support-default-responses
branch
from
July 17, 2026 10:42
b077e03 to
a450ff9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that the python client actually respects the default response type instead of returning None. Making is much more useful.
Would fix #11793 for the python generator.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
@cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10)
Summary by cubic
Honor OpenAPI
defaultresponses in Python clients by deserializing them when no explicit status mapping matches (including invalid or out-of-range statuses). Fixes #11793.'default'only when no exact orXxxclass match exists, status is missing/invalid/out-of-range, and'default'is defined in the map.partial_api.mustache, emit'default'in_response_types_mapfor wildcard responses only when a schema is present.'default'mapping (aiohttp,httpx,httpx-sync, sync,lazyImports, echo_api, legacy-model-dictionaries).Written for commit a450ff9. Summary will update on new commits.