fix(app): configure http with proxy url if present in environment

[jontze]

This PR adjusts the HttpModule configuration to apply proxy configuration from the https-proxy-agent package if the HTTP_PROXY or HTTPS_PROXY environment variables are present.

Should Close #714
Related to #752 (similar approach)

Why

(taken from #752)

HTTPS for corporate proxies doesn't work after #651 because it assumed that @nestjs/axios took care of correctly extracting proxy configuration from the environment variables. In reality, axios proxy setup is broken as mentioned in https://stackoverflow.com/a/53399378 and axios/axios#2072 (comment).

[wing328]

@taras I wonder if you can review this change when you've time. Thank you.

[jontze]

I rebased my branch to the latest master.

[wing328]

@jontze thanks. Have you tested it locally to confirm the fix?

[jontze]

@jontze thanks. Have you tested it locally to confirm the fix?

@wing328 Yes, I've been using the patch on my fork since the PR was created to work around the issue locally and haven't encountered any problems so far.

[wing328]

Thanks @jontze let's give it a try

[github-actions]

🎉 This PR is included in version 2.13.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[wing328]

did a test with the latest release and it's working for m

thanks again for the PR

[berkitamas]

Hi,

This PR pretty much broke our setup. We have a local mirror which is set by generator-cli.repository.downloadUrl. That endpoint lives in the intranet. We have HTTPS_PROXY, HTTP_PROXY and NO_PROXY values set up in our environment. By checking the change, it looks like the values of NO_PROXY are ignored, and that is the culprit in our case (the mirror is set in NO_PROXY).

[wing328]

@berkitamas thanks for reporting the issue. Please rollback to the previous version for the time being.

@jontze can you please take a look at the issue when you've time?

[jontze]

I'll take a look and try to come up with a solution that respect NO_PROXY .

[jontze]

@wing328 I opened #781 to address this.

@berkitamas It would be amazing if you could verify the bugfix, if you have the time.