fix: correct NEO_DB singleton mock in gap_analysis test#757
Open
Subh24ai wants to merge 1 commit intoOWASP:mainfrom
Open
fix: correct NEO_DB singleton mock in gap_analysis test#757Subh24ai wants to merge 1 commit intoOWASP:mainfrom
Subh24ai wants to merge 1 commit intoOWASP:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_tiered_execution_optimizationwas failing with:TypeError: NEO_DB.gap_analysis() missing 1 required positional argument: 'name_2'This happened because the test called
db.NEO_DB.gap_analysis()directlyon the class, but
NEO_DBis a singleton that must be accessed viaNEO_DB.instance().Fix
Updated
setUp()to instantiateNEO_DBcorrectly usingNEO_DB.instance()and call
gap_analysis()on the instance instead of the class.Result
Test now passes without requiring a running Neo4j instance.