v1.0.1 prep#8
Merged
Merged
Conversation
added 2 commits
May 31, 2026 15:51
…es to align with API specifications, fixing TypeScript type errors for ListVocabulariesOptions, VocabularyConceptsOptions, and BasicSearchOptions.
…anonical path `GET /v1/search/semantic`, while maintaining the legacy alias for backward compatibility. Bump version in package.json and version.ts, and update CHANGELOG accordingly.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/search/interfaces/basic-search-options.ts">
<violation number="1" location="src/search/interfaces/basic-search-options.ts:14">
P2: This narrows a public exported union and introduces a backward-incompatible TypeScript API change. Keep old `sortBy` literals as aliases (at least temporarily) to avoid breaking consumers on upgrade.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| minScore?: number; | ||
| exactMatch?: boolean; | ||
| sortBy?: 'relevance' | 'name' | 'concept_count' | 'last_updated'; | ||
| sortBy?: 'relevance' | 'name' | 'code' | 'date'; |
There was a problem hiding this comment.
P2: This narrows a public exported union and introduces a backward-incompatible TypeScript API change. Keep old sortBy literals as aliases (at least temporarily) to avoid breaking consumers on upgrade.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/search/interfaces/basic-search-options.ts, line 14:
<comment>This narrows a public exported union and introduces a backward-incompatible TypeScript API change. Keep old `sortBy` literals as aliases (at least temporarily) to avoid breaking consumers on upgrade.</comment>
<file context>
@@ -11,6 +11,6 @@ export interface BasicSearchOptions extends PaginationOptions {
minScore?: number;
exactMatch?: boolean;
- sortBy?: 'relevance' | 'name' | 'concept_count' | 'last_updated';
+ sortBy?: 'relevance' | 'name' | 'code' | 'date';
sortOrder?: 'asc' | 'desc';
}
</file context>
Suggested change
| sortBy?: 'relevance' | 'name' | 'code' | 'date'; | |
| sortBy?: | |
| | 'relevance' | |
| | 'name' | |
| | 'code' | |
| | 'date' | |
| | 'concept_count' | |
| | 'last_updated'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Prep for v1.0.1:
client.search.semantic()now callsGET /v1/search/semantic(legacy alias still supported), and the SDK version is bumped to 1.0.1. Fixes incorrectsortByenums to match the API.sortByoptions:ListVocabulariesOptions→'name' | 'priority' | 'updated';VocabularyConceptsOptions→'name' | 'concept_id' | 'concept_code';BasicSearchOptions→'relevance' | 'name' | 'code' | 'date'.Written for commit 5c25511. Summary will update on new commits.