Skip to content

v1.0.1 prep#8

Merged
alex-omophub merged 2 commits into
mainfrom
develop
Jun 1, 2026
Merged

v1.0.1 prep#8
alex-omophub merged 2 commits into
mainfrom
develop

Conversation

@alex-omophub

@alex-omophub alex-omophub commented Jun 1, 2026

Copy link
Copy Markdown
Member

Summary by cubic

Prep for v1.0.1: client.search.semantic() now calls GET /v1/search/semantic (legacy alias still supported), and the SDK version is bumped to 1.0.1. Fixes incorrect sortBy enums to match the API.

  • Bug Fixes
    • Updated sortBy options: ListVocabulariesOptions'name' | 'priority' | 'updated'; VocabularyConceptsOptions'name' | 'concept_id' | 'concept_code'; BasicSearchOptions'relevance' | 'name' | 'code' | 'date'.

Written for commit 5c25511. Summary will update on new commits.

Review in cubic

alex-omophub added 2 commits May 31, 2026 15:51
…es to align with API specifications, fixing TypeScript type errors for ListVocabulariesOptions, VocabularyConceptsOptions, and BasicSearchOptions.
…anonical path `GET /v1/search/semantic`, while maintaining the legacy alias for backward compatibility. Bump version in package.json and version.ts, and update CHANGELOG accordingly.
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 9 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/search/interfaces/basic-search-options.ts">

<violation number="1" location="src/search/interfaces/basic-search-options.ts:14">
P2: This narrows a public exported union and introduces a backward-incompatible TypeScript API change. Keep old `sortBy` literals as aliases (at least temporarily) to avoid breaking consumers on upgrade.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

minScore?: number;
exactMatch?: boolean;
sortBy?: 'relevance' | 'name' | 'concept_count' | 'last_updated';
sortBy?: 'relevance' | 'name' | 'code' | 'date';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This narrows a public exported union and introduces a backward-incompatible TypeScript API change. Keep old sortBy literals as aliases (at least temporarily) to avoid breaking consumers on upgrade.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/search/interfaces/basic-search-options.ts, line 14:

<comment>This narrows a public exported union and introduces a backward-incompatible TypeScript API change. Keep old `sortBy` literals as aliases (at least temporarily) to avoid breaking consumers on upgrade.</comment>

<file context>
@@ -11,6 +11,6 @@ export interface BasicSearchOptions extends PaginationOptions {
   minScore?: number;
   exactMatch?: boolean;
-  sortBy?: 'relevance' | 'name' | 'concept_count' | 'last_updated';
+  sortBy?: 'relevance' | 'name' | 'code' | 'date';
   sortOrder?: 'asc' | 'desc';
 }
</file context>
Suggested change
sortBy?: 'relevance' | 'name' | 'code' | 'date';
sortBy?:
| 'relevance'
| 'name'
| 'code'
| 'date'
| 'concept_count'
| 'last_updated';

@alex-omophub alex-omophub merged commit 8b5baf5 into main Jun 1, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant