Skip to content

[IMP] queue_job: Handle TypeError when JSON-encoding context. - #936

Open
amh-mw wants to merge 1 commit into
OCA:18.0from
amh-mw:18.0-encode-object-as-null
Open

amh-mw wants to merge 1 commit into
OCA:18.0from
amh-mw:18.0-encode-object-as-null

Conversation

@amh-mw

@amh-mw amh-mw commented May 19, 2026

Copy link
Copy Markdown
Member

This nulls out unencodable values when serializing the job context, instead of raising an error.

This nulls out unencodable values when serializing the job context, instead of raising an error.
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @guewen, @sbidoul,
some modules you are maintaining are being modified, check this out!

@amh-mw
amh-mw marked this pull request as ready for review May 19, 2026 15:34
@amh-mw

amh-mw commented May 19, 2026

Copy link
Copy Markdown
Member Author

I am of the opinion that queue_job should not be in the context-management game, so this is an effort to increase durability when the context may not have been curated.

@sbidoul

sbidoul commented May 19, 2026

Copy link
Copy Markdown
Member

I don't know. I personally prefer fast and explicit failures than silent degradation that would be harder to diagnose.

What is the use case?

@amh-mw

amh-mw commented May 19, 2026

Copy link
Copy Markdown
Member Author

I'm currently running a variant of #768 where I ripped out all of the context management code. Then when I adopted queue_job_batch, I started getting JSON encoding errors.

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:queue_job Module queue_job series:18.0 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants