[18.0][FIX] connector_importer: Fix skip_fields_unchanged behaviour - #190
Open
rousseldenis wants to merge 1 commit into
Open
rousseldenis wants to merge 1 commit into
rousseldenis wants to merge 1 commit into
Conversation
Contributor
|
Hi @simahawk, |
rousseldenis
force-pushed
the
18.0-fix-skip-fields-dro
branch
from
September 18, 2026 12:41
104d7fe to
2f3542a
Compare
rousseldenis
changed the title
| if values[k] != v: | ||
| # Some fields like 'id' are loaded by read() and are not necessary in | ||
| # write values. | ||
| if k in values and values[k] == v: |
Member
There was a problem hiding this comment.
Something like this is not working?
Suggested change
| if k in values and values[k] == v: | |
| if values.get(k, False) == v: |
FrancoMaxime
left a comment
FrancoMaxime
left a comment
Member
There was a problem hiding this comment.
LGTM: code review
a minor question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.