Skip to content

[fix] Add trailing slash to local directory for uploads to existing cloud directory with fsspec #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SumanthRH merged 2 commits into from
May 3, 2026
Merged

[fix] Add trailing slash to local directory for uploads to existing cloud directory with fsspec #1614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
443358c
fix: add trailing slash to local directory for uploads to existing cl…
SumanthRH May 3, 2026
f216741
x
SumanthRH May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions skyrl/backends/skyrl_train/utils/io/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@ def upload_directory(local_path: str, cloud_path: str) -> None:
raise ValueError(f"Destination must be a cloud path, got: {cloud_path}")

fs = _get_filesystem(cloud_path)
# NOTE (sumanthrh): While uploading files in a directory `src` to an existing directory `dst` with fsspec,
# we need to ensure that the file path ends in a trailing slash. otherwise, fsspec will create a subdirectory
# `dst/src` instead of directly syncing contents of `src` into the root `dst` directory
local_path = os.path.join(local_path, "")
if cloud_path.startswith("s3://"):
call_with_s3_retry(fs, fs.put, local_path, fs._strip_protocol(cloud_path), recursive=True)
else:
Expand Down
Loading