wayfire: update ecosystem to 0.11.0-unstable#492535
Conversation
nixpkgs-ci
Bot
added
8.has: package (new)
hustlerone
force-pushed
the
wayfire
branch
2 times, most recently
from
ede86b0 to
6fe96a0
Compare
| security = { | ||
| polkit.enable = true; | ||
| pam.services.swaylock = { }; | ||
| pam.services.wf-locker = { }; |
There was a problem hiding this comment.
I can't find anything about a wf-locker service. Can you link where you found it?
There was a problem hiding this comment.
We do the same thing for swaylock.
If I recall correctly, it'll most likely be handled by home manager (in the future).
There was a problem hiding this comment.
There should be no reason to patch GitHub work flow files.
There was a problem hiding this comment.
WayfireWM/wf-shell#349 has been merged so the diff can be withdrawn now
| wcm = callPackage ./wcm.nix { }; | ||
| wf-shell = callPackage ./wf-shell.nix { }; | ||
| wf-shell = callPackage ./wf-shell { }; | ||
| pixdecor = callPackage ./pixdecor.nix { }; |
There was a problem hiding this comment.
This could cause some issue since wayfire-plugins-extra also includes pixdecor.
Files from later plugins don't overwrite already existing ones, but there are no warning about conflicts during rebuilds (nix does log something when building wayfire-wrapped, but this is easily missed).
So this would use the newer pixdecor:
programs.wayfire = {
enable = true;
plugins = with pkgs.wayfirePlugins; [
pixdecor
wayfire-plugins-extra
];
};But this one wouldn't:
programs.wayfire = {
enable = true;
plugins = with pkgs.wayfirePlugins; [
wayfire-plugins-extra
pixdecor
];
};I'd prefer if we'd push for the open PR in wayfire-plugins-extra to be merged/updated: WayfireWM/wayfire-plugins-extra#312
(Or patch the submodule to use a newer pixdecor version.)
I'm generally unsure about using an unstable Wayfire version in nixpkgs because this would mean dealing more with plugin conflicts (what if someone wants Wayfire from commit XY because it adds support for a useful Wayland protocol, but some plugins aren't compatible with the development version yet?)
There was a problem hiding this comment.
I actually haven't noticed pixdecor being there.
As for compatibility, other than wf-config's breaking change I don't think it's going to be a big deal.
I'll withdraw the separate pixdecor addition.
Bumps wayfire, wf-shell, wf-plugins-extras and wf-config.
There was a problem hiding this comment.
I looked through the current dependencies, and we can remove the following ones:
- libinput
- libxkbcommon
- gtkmm3
We can add glibmm (giomm) to enable an additional plugin.
I also had to add libGL to the dependencies.
| }; | ||
|
|
||
| nativeBuildInputs = [ | ||
| meson | ||
| ninja | ||
| pkg-config | ||
| wayland-scanner | ||
| vala | ||
| gobject-introspection | ||
| ]; | ||
|
|
||
| buildInputs = [ |
There was a problem hiding this comment.
I also needed libgbm for wf-shell to build.
|
Unrelated but I wonder how best to work with the propagated build inputs. The |
yea sure we could try that but i doubt we can gain much from it |
2 participants
Updates the whole ecosystem.
Adds pixdecor, updates wayfire-plugins-extra to latest. Now you can enjoy the burn and carpet animations. These are the more notable changes one might look for.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.