Skip to content

nk app 1: add download links for nitrokey app 1 (#570)#585

Merged
jans23 merged 10 commits into
mainfrom
push-llwpnrvzmkyl
Jul 9, 2026
Merged

nk app 1: add download links for nitrokey app 1 (#570)#585
jans23 merged 10 commits into
mainfrom
push-llwpnrvzmkyl

Conversation

@blu-nitro

Copy link
Copy Markdown
Member

closes #570

@blu-nitro blu-nitro requested a review from jans23 June 1, 2026 17:44
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

The successful documentation build for e1a57bf was deployed for preview:

generated by workflow run 29012552418 (attempt 1)

@jans23

jans23 commented Jun 2, 2026

Copy link
Copy Markdown
Member

The section for Ubuntu is missing. Is this on purpose?

@jans23

jans23 commented Jun 3, 2026

Copy link
Copy Markdown
Member

The first sentences are redundant.

The list should be sorted alphabetically.

Fix dead links:

  • "cask" in macos
  • "is part" in nixos
  • "is part" in gentoo

@ABuljko

ABuljko commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

In https://www.nitrokey.com/download/appimage-flatpak-snap

"AppImage, Flatpak, Snap" is the main title while each section behaves like a subtitle
But in the code each are like their own title. Should remake it like in the app? (the ubuntu section has a link to in the www.nitrokey so i would like that so it is still connected as before)

@ABuljko

ABuljko commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Gentoo

There's a working archive.org snapshot from November 12, 2024 (just before the package was removed):
https://web.archive.org/web/20241112195418/https://github.com/gentoo/gentoo/tree/master/app-crypt/nitrokey-app

Maybe we could use that as a reference link alongside the "package removed" note, so Gentoo users can still see the historical ebuild.

NixOs

https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name/ni/nitrokey-app

The package moved locations in nixpkgs but is still active. That link should be working.
Should I add it instead?

macOS

Could not find an alternative (should I remove it and look for an alternative)

@jans23

jans23 commented Jul 1, 2026

Copy link
Copy Markdown
Member

"AppImage, Flatpak, Snap" should be individual sections (as you have it already).

Remove sections Gentoo and Homebrew as well as title "Single-file download".

Yes, update the link for NixOS.

@ABuljko

ABuljko commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

In the https://www.nitrokey.com/download/ubuntu
The text link "here" leads to the section containing all three
I would have to change the text a bit since in the code they are registered as separate

@jans23

jans23 commented Jul 2, 2026

Copy link
Copy Markdown
Member

No need for these clickable sections in Windows, macOS, FreeBSD, and Source.

@jans23

jans23 commented Jul 8, 2026

Copy link
Copy Markdown
Member

Update the hyperlink in nk-app2.rst

@ABuljko ABuljko force-pushed the push-llwpnrvzmkyl branch from 5f08a20 to e9bb8ba Compare July 9, 2026 10:21
@jans23

jans23 commented Jul 9, 2026

Copy link
Copy Markdown
Member

@ABuljko you need to fix the CI tests.

@ABuljko

ABuljko commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

@jans23 can I do the honors haha

@jans23 jans23 merged commit bfd53bf into main Jul 9, 2026
7 checks passed
@jans23 jans23 deleted the push-llwpnrvzmkyl branch July 9, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add NK App 1

3 participants