Skip to content

Show absolute epoch number in resume progress bar#1639

Open
dxqb wants to merge 1 commit into
Nerogar:masterfrom
dxqb:fix-resume-epoch-progress-squashed
Open

Show absolute epoch number in resume progress bar#1639
dxqb wants to merge 1 commit into
Nerogar:masterfrom
dxqb:fix-resume-epoch-progress-squashed

Conversation

@dxqb

@dxqb dxqb commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

The epoch progress bar iterated range(resume_epoch, total_epochs) with no initial/total, so on resume it showed the count of remaining epochs starting from 0 (e.g. 1/50) instead of the absolute position (51/100). This adds initial=train_progress.epoch, total=self.config.epochs, matching how the step bar just below it already resumes.

Cosmetic only -- train_progress.epoch and the LR schedule were already correct; this only fixes the display. Surfaced while investigating #1604.

Test plan

  • pre-commit run --all-files passes
  • Launched the affected UI or script and exercised the change
  • Tested with at least one real preset / config when relevant (note which: ____)

AI assistance

  • AI-assisted -- I have read every line in this diff and can defend each change

The epoch progress bar iterated `range(resume_epoch, total_epochs)` with no `initial`/`total`, so on resume it showed the count of *remaining* epochs starting from 0 (e.g. `1/50`) instead of the absolute position (`51/100`). This adds `initial=train_progress.epoch, total=self.config.epochs`, matching how the step bar just below it already resumes.

Cosmetic only — `train_progress.epoch` and the LR schedule were already correct; this only fixes the display. Surfaced while investigating Nerogar#1604.
@dxqb dxqb added the preview merged in the preview branch label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview merged in the preview branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant