Show absolute epoch number in resume progress bar#1639
Open
dxqb wants to merge 1 commit into
Open
Conversation
The epoch progress bar iterated `range(resume_epoch, total_epochs)` with no `initial`/`total`, so on resume it showed the count of *remaining* epochs starting from 0 (e.g. `1/50`) instead of the absolute position (`51/100`). This adds `initial=train_progress.epoch, total=self.config.epochs`, matching how the step bar just below it already resumes. Cosmetic only — `train_progress.epoch` and the LR schedule were already correct; this only fixes the display. Surfaced while investigating Nerogar#1604.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The epoch progress bar iterated
range(resume_epoch, total_epochs)with noinitial/total, so on resume it showed the count of remaining epochs starting from 0 (e.g.1/50) instead of the absolute position (51/100). This addsinitial=train_progress.epoch, total=self.config.epochs, matching how the step bar just below it already resumes.Cosmetic only --
train_progress.epochand the LR schedule were already correct; this only fixes the display. Surfaced while investigating #1604.Test plan
pre-commit run --all-filespassesAI assistance