Skip to content

Add toggles for cmake unity build - #2052

Merged
nullsystem merged 1 commit into
NeotokyoRebuild:masterfrom
nullsystem:CMakeUnityToggle
Aug 7, 2026
Merged

Add toggles for cmake unity build#2052
nullsystem merged 1 commit into
NeotokyoRebuild:masterfrom
nullsystem:CMakeUnityToggle

Conversation

@nullsystem

@nullsystem nullsystem commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Description

One for client/server and one for vgui2/tier1/mathlib as may want to turn it off only for working on just client/server library side. Also fixup compile/linker errors since the changes and add NEO_UNITY defines to fixup for those ifdef changes.

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native Arch/GCC 16

Linked Issues

  • fixes #
  • related #

@nullsystem
nullsystem requested a review from a team August 5, 2026 17:14
@nullsystem
nullsystem marked this pull request as draft August 5, 2026 17:15
One for client/server and one for vgui2/tier1/mathlib as may want to
turn it off only for working on just client/server library side. Also
fixup compile/linker errors since the changes and add NEO_UNITY
defines to fixup for those ifdef changes. Add info in README.
@nullsystem
nullsystem marked this pull request as ready for review August 5, 2026 17:31

@Rainyan Rainyan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on Win11 with MSVC 2022 and toggling the new options in CMakeLists.txt and then running "Project" -> "Delete Cache and Reconfigure" and "Build" -> "Rebuild All" to force the non-unity rebuild.

@Rainyan
Rainyan requested a review from a team August 5, 2026 19:25
Comment thread src/game/client/viewpostprocess.cpp

@Masterkatze Masterkatze left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nullsystem
nullsystem merged commit ad91e07 into NeotokyoRebuild:master Aug 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants