Skip to content

docs: fix relative links to existing doc pages#2879

Open
CTOmari360 wants to merge 1 commit into
NVIDIA:mainfrom
CTOmari360:docs/fix-broken-doc-links
Open

docs: fix relative links to existing doc pages#2879
CTOmari360 wants to merge 1 commit into
NVIDIA:mainfrom
CTOmari360:docs/fix-broken-doc-links

Conversation

@CTOmari360

Copy link
Copy Markdown

Several documentation pages link to other pages using relative paths that overshoot their directory, so the links resolve to non-existent files even though the target pages exist in the tree. This corrects the relative paths to point at the existing files.

File Link Fix
docs/faq.md ../architecture/health_aggregation.md architecture/health_aggregation.md
docs/faq.md ../observability/core_metrics.md observability/core_metrics.md
docs/development.md vm_pxe_client.md development/vm_pxe_client.md
docs/architecture/overview.md dpu_configuration.md ../dpu-management/dpu_configuration.md
docs/operations/tenant-lifecycle-cleanup.md ../manuals/metrics/core_metrics.md ../observability/core_metrics.md

Each corrected link was verified to resolve to an existing file.

Related issues

None.

Type of Change

  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • No testing required (docs, internal refactor, etc.)

Verified each new relative path resolves to a file that exists in the repository.

Additional Notes

Scope is intentionally limited to broken links whose intended target unambiguously exists. Links to pages that no longer exist anywhere in the tree (e.g. day_one_operations.md, nico_admin_cli.md) are deliberately left out, since their correct targets are ambiguous. Auto-generated CLI reference docs are also out of scope.

Several documentation pages linked to other pages using relative paths
that overshoot their directory, so the links resolve to non-existent
files even though the target pages exist. Correct the paths to point at
the existing files:

- docs/faq.md -> architecture/health_aggregation.md, observability/core_metrics.md
- docs/development.md -> development/vm_pxe_client.md
- docs/architecture/overview.md -> ../dpu-management/dpu_configuration.md
- docs/operations/tenant-lifecycle-cleanup.md -> ../observability/core_metrics.md

Links to pages that no longer exist anywhere in the tree are left out of
this change, since their intended targets are ambiguous.

Signed-off-by: Omar Refai <omar@refai.org>
@CTOmari360 CTOmari360 requested a review from a team as a code owner June 25, 2026 10:52
@copy-pr-bot

copy-pr-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c0a23eb8-60bf-4996-8352-58a5b749d702

📥 Commits

Reviewing files that changed from the base of the PR and between 852c517 and c3c5ae8.

📒 Files selected for processing (4)
  • docs/architecture/overview.md
  • docs/development.md
  • docs/faq.md
  • docs/operations/tenant-lifecycle-cleanup.md

Summary by CodeRabbit

  • Documentation
    • Updated several documentation links to point to the correct current pages.
    • Improved navigation across architecture, development, FAQ, and operations docs by fixing broken or outdated references.
    • Adjusted references for DPU configuration, QEMU server setup, health aggregation, core metrics, and tenant lifecycle cleanup content.

Walkthrough

Updated several documentation links so references on architecture, development, FAQ, and operations pages point to the current relative paths.

Changes

Documentation path updates

Layer / File(s) Summary
Reference link corrections
docs/architecture/overview.md, docs/development.md, docs/faq.md, docs/operations/tenant-lifecycle-cleanup.md
Updated documentation links to newer relative targets for DPU configuration, QEMU server setup, health aggregation, Core Metrics, and tenant lifecycle cleanup references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the PR’s main change: fixing broken relative documentation links.
Description check ✅ Passed The description clearly matches the changeset and explains the documentation link fixes in scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant