Repository navigation
Fix Pyxis host-wide user namespace override cleanup - #1420
Merged
Merged
Conversation
Retract only the role-owned global override and replay the target key through systemd-sysctl on every opt-out run. Preserve unrelated policy, report unresolved permissive state, and never guess a historical value. Check mode predicts cleanup without replaying host policy. Add offline regression coverage using real Ansible and sysctl tools against namespace-isolated files, including policy precedence and retries. Signed-off-by: Doug Holt <dholt@nvidia.com> Co-Authored-By: Paperclip <noreply@paperclip.ing>
michael-balint
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1412.
What changes
Removal uses lineinfile rather than the sysctl module because the latter normalizes unrelated entries and removes duplicate keys even with reload disabled.
Validation
No live-host validation or branch CI result is claimed. Package installation, AppArmor profile loading, and Slurm execution are outside the offline fixture.