fix: prevent memory leak by reusing gRPC conn to kubelet pod-resource… - #705
Open
AshwinRamaniPsg wants to merge 1 commit into
Open
fix: prevent memory leak by reusing gRPC conn to kubelet pod-resource…#705AshwinRamaniPsg wants to merge 1 commit into
AshwinRamaniPsg wants to merge 1 commit into
Conversation
Author
|
@nccurry would you be able to help review this PR please |
Collaborator
|
Could you please rebase in PR |
Author
Done |
…s API - Add persistent grpcConn to PodMapper, reused across scrapes instead of creating a new *grpc.ClientConn on every /metrics request (issue NVIDIA#702) - Reset cached conn on RPC error to handle kubelet restarts - Move resolver.SetDefaultScheme to one-time init in NewPodMapper - Clone labels map per entity in expCollector and gpuHealthStatusCollector to prevent cross-GPU label pollution and extra GC pressure - Add tests: connection reuse, reconnect after shutdown, Stop() cleanup
Author
|
@rvatkar can you please help review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s API