Fix cuvs build due to rmm and cuCollections api changes - #2504
Conversation
Zeroed with a device memset. The device_scalar(value, stream) ctor would copy from a host temporary that dies before the copy is guaranteed to have read it.
Unrelated but same type of bug (found by AI).
|
For some reason local builds are failing for me in some |
|
Hmmm, ok, also seeing the same failures here. At least I know it's not just my env then! Looks like some other upstream change has also broken things, beyond just the |
|
Ah, it's rapidsai/rmm#2527, which broke some code in |
Just FWIW, that code in raft was always wrong, sorry :( |
|
Build failures due to |
|
I've folded in the changes from #2503 as well, since both PRs will be needed to fix the cuvs builds. I also had to push a small fixup there to handle a few missed cases. |
cuco::bloom_filter_policycuvs build due to rmm and cuCollections api changes
|
/merge |
rapids-cmakejust bumped the commit used forcuCollectionsin builds, leading tocuvsbuild failures.Here we fix usage of
cuco::default_filter_policythat were changed in NVIDIA/cuCollections#827.Also fixes some fallout from rapidsai/rmm#2527, merging in #2503 (as well as a few small fixups).
Closes #2503.