[REVIEW] Fix padded dataset creation for aligned device tensors - #2501
Open
Sharon05564 wants to merge 1 commit into
Open
[REVIEW] Fix padded dataset creation for aligned device tensors#2501Sharon05564 wants to merge 1 commit into
Sharon05564 wants to merge 1 commit into
Conversation
Author
|
Hi! The label checker is currently failing because the PR is missing the required category and breaking-change labels. Could a maintainer please add the appropriate labels? This is a bug fix and is intended to be non-breaking. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
cuvsDatasetMakePadded()rejecting device tensors whose row stride already satisfies the required padding alignment.Previously, an already-aligned device tensor caused the padded-dataset helper to return an error and the Python binding worked around this by inspecting the error message and falling back to a non-owning padded view.
This change:
force_copypath to the padded-dataset helperscuvsDatasetMakePadded()always returns an owning copycuvsDatasetMakePaddedView()remains a non-owning aliasTesting
Added/updated C++ and Python regression tests covering the aligned-device case and padded-view behavior.
Local static, Cython, formatting, and Python checks passed. CUDA/C++ runtime tests could not be run locally because the development environment does not have a CUDA toolkit or GPU, so those checks are left to project CI.
Fixes #2482