Repository navigation
Conversation
_validate_opt_level let None through (also inside ByTarget), and the kernel signature advertised None, but opt_level_for_target asserts an int. So ct.kernel(opt_level=None) or ByTarget(sm_90=None) was accepted and then failed with a bare AssertionError when the cubin was compiled. Require an integer in [0, 3] and drop None from the signature. Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ct.kernel(opt_level=None)(orct.ByTarget(sm_90=None)foropt_level) passes validation, since_validate_opt_levelskipsNoneand thekernelsignature lists it, butopt_level_for_targetasserts anint. The kernel is accepted and then fails with a bareAssertionErrorthe first time the cubin is compiled.This PR requires an integer in [0, 3] at definition time (also for
ByTargetvalues and defaults) and dropsNonefrom the signature.Checked on GH200 (CUDA 13.2):
AssertionError().ValueError: opt_level should be an integer in [0, 3], got Noneat definition.The new test cases (
None, -1, 4,ByTarget(sm_100=None),ByTarget(default=None)) pass against the built extension. I couldn't run the whole oftest_compiler_options.pybecause no GPU was free.Checklist