Skip to content

[CI] Log WoA resolution checks and skip ineligible runs - #3349

Merged
leofang merged 1 commit into
NVIDIA:mainfrom
isVoid:codex/woa-resolver-diagnostics
Nov 4, 2026
Merged

leofang merged 1 commit into
NVIDIA:mainfrom
isVoid:codex/woa-resolver-diagnostics

Conversation

@isVoid

@isVoid isVoid commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

The public WoA resolver currently exits with a silent assertion failure when a selected run is outside its eligible scope. For example, the resolve-public-build failure in run 41704819123 does not record the API response or identify which condition failed.

Log the public run metadata, the result of every eligibility check, and the commit comparison against main. Ineligible runs now emit a notice and a skip reason in the CI summary, then skip batch selection and private dispatch. The existing eligibility rules remain unchanged; API, parsing, and unexpected script errors still fail with an error annotation containing the script line and exit code.

Validation:

  • Actionlint, YAML parsing, Bash syntax, SPDX headers, and git diff --check passed.
  • Exercised 19 simulated scenarios using the actual resolver script, covering eligible runs, queued/failed/cancelled runs, repository/workflow/branch/SHA mismatches, main ancestry, manual lookup, and API failures.
  • No live private dispatch or GB10 run was launched.

Signed-off-by: isVoid <13521008+isVoid@users.noreply.github.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label Nov 3, 2026
@isVoid
isVoid marked this pull request as ready for review November 3, 2026 22:42
@isVoid isVoid self-assigned this Nov 3, 2026
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Public build checks now provide clearer failure details and report when a run is skipped because it does not meet eligibility requirements.
    • Batch selection runs only after a build is confirmed eligible. Comparison results are logged before the existing checks are applied.

The WoA public build workflow now logs resolution details, reports failed eligibility checks, and skips ineligible runs. Batch selection runs only when resolution marks a run eligible.

Changes: WoA public build resolution

Layer / File(s) Summary
Resolve and report eligibility
.github/workflows/woa-main-ci.yml
The resolver logs run metadata and failed eligibility checks. It logs commit comparison results, skips runs that fail eligibility or comparison, and sets eligible=true after successful resolution.
Gate batch selection
.github/workflows/woa-main-ci.yml
The dispatch output defaults to false. Batch selection runs only when resolution sets eligible=true.

Possibly related PRs

Suggested labels: github_actions

Suggested reviewers: rwgk, leofang

Change: Bug fix

Merge Risk: Minimal · up to 9e77c

The change makes the public WoA resolver log why a run is skipped and runs batch selection only for eligible runs. The path-suffix concern was checked against real runs and does not apply. No remaining merge-blocking risk is identified.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 526b119 and 9e77ce8.

Files selected for processing: 1
  • .github/workflows/woa-main-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@isVoid isVoid added the bug Something isn't working label Nov 3, 2026
@isVoid isVoid added this to the CI milestone Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@leofang
leofang merged commit 4010017 into NVIDIA:main Nov 4, 2026
119 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI/CD CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants