Use the right type of infinity so we don't get a compiler warning.#22
Closed
ThiagoIze wants to merge 1 commit intoNVIDIA:mainfrom
Closed
Use the right type of infinity so we don't get a compiler warning.#22ThiagoIze wants to merge 1 commit intoNVIDIA:mainfrom
ThiagoIze wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Merged
Collaborator
|
CI broke on some (tiny) missing typecast. Already fixed but haven't figure out to modify the existing PR, so going to fix this through a new PR #24 (which is a pull of your diffs plus that typecast) |
Collaborator
|
BTW the entire PosInfTy() etc isn't actually used all that much in cuBQL - it's pretty much a leftover from embree.... but now that you point that it's there I agree it's probably the right way of doing these constants in other places too. |
Collaborator
|
handling this through PR #24, closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on the windows toolkit being used on Windows (and maybe whatever #defines are set?) we can get compiler warnings like:
This happens because INFINITY can be defined by Windows toolkit to be 1e300:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\ucrt\corecrt_math.h
cubql already has functions to do this properly, so I went ahead and used that.