Merged
Conversation
One can now do something like:
scene:createArray("name", { {1, 2, 3}, {4, 5, 6}}) to create a 2d array
Same one can do
myobj:setParameterArray("parameter", {{{1, 2}, {3, 4}}, {{5, 6}, {7, 8}}}) to assign a 3d array
A simplified Array that can hold Object or scalar values. Host only.
Scene represents a spatial snapshot (geometry, materials, instances) and should be stateless with respect to time. Move SceneAnimation ownership to TSDState in Context.h, making animation an application-level concern. SceneAnimation is now default-constructible; its mutating methods take a Scene& at call time instead of storing one at construction. Importers and serialization accept an optional SceneAnimation* parameter — when null, animation data is silently skipped.
In preparation for templetization of the class.
0bf42fb to
14cac7f
Compare
Collaborator
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the animation system so:
Next steps: