Repository navigation
[None][infra] Waive 1 failed cases for main in pre-merge 66696 - #21140
Conversation
Bug(s): 7003528 Requested by: @HuiGao-NV Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "skip one test group of main break" |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Connector test waiver tests/integration/test_lists/waives.txt |
The list now skips unittest/_torch/test_connector_adp.py and records tracking reference 7003528. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related PRs
- NVIDIA/TensorRT-LLM#19369: Adds the connector test file that this change waives.
Suggested reviewers: leslie-fang25
Merge Risk: 
7409b
-
No merge-blocking risk is identified in this targeted test-waiver change.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly identifies an infrastructure change that waives one failed test case for the main branch. It uses the required ticket and type format. Description check The description clearly states the waiver entry, target branch, related NVBug, requester, and automated creation context. It does not include separate Test Coverage or PR Checklist sections, but those… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description clearly states the waiver entry, target branch, related NVBug, requester, and automated creation context. It does not include separate Test Coverage or PR Checklist sections, but those omissions are non-critical for this auto-generated waiver change.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
PR_Github #81011 [ skip ] triggered by Bot. Commit: |
|
PR_Github #81011 [ skip ] completed with state |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @HuiGao-NV)
Target branch:
mainBug(s): 7003528
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
The change adds one
SKIPwaiver forunittest/_torch/test_connector_adp.py, linked to NV bug 7003528. The change is limited to the test list; it does not alter source code or public APIs.QA Engineer Review
tests/integration/test_lists/waives.txtadds a waiver forunittest/_torch/test_connector_adp.py. The test path also appears intests/integration/test_lists/test-db/l0_cpu.yml, so it remains listed in that CI test list. The waiver skips the test where it applies, which reduces test execution. Coverage verdict: needs follow-up until the failure is resolved and the waiver is removed. Test execution results are not provided.Per-File QA Perspective
tests/integration/test_lists/waives.txt: Adds aSKIPwaiver forunittest/_torch/test_connector_adp.py, linked to bug 7003528. The test is listed intests/integration/test_lists/test-db/l0_cpu.yml; QA should confirm the waiver scope and remove it when no longer needed.