Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f554f80
fix: keep release credentials out of the build checkout
yashrajp22 Oct 5, 2026
ca9ba62
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 6, 2026
61c99ce
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 6, 2026
def0c85
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 6, 2026
e5fcd1c
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 6, 2026
0d53d47
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 6, 2026
9533276
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 6, 2026
78a7797
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 6, 2026
484f4ef
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 6, 2026
848ad08
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 6, 2026
c3ff1df
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 6, 2026
3129853
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 6, 2026
93a4a3f
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 6, 2026
2378fb4
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 7, 2026
942a8bc
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 7, 2026
d1426b4
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 7, 2026
e98a6e8
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 8, 2026
d6eb174
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 8, 2026
2f4fd7e
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 8, 2026
e4241c9
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 9, 2026
36bea22
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 9, 2026
daee80b
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 9, 2026
63646b5
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 9, 2026
2f32ac9
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 9, 2026
08bc421
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 9, 2026
e96d603
Merge branch 'main' into yashraj/release-checkout-credential-followup…
github-actions[bot] Oct 9, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@ jobs:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
ref: ${{ github.event.pull_request.merge_commit_sha }}
persist-credentials: false
- name: Set up uv
# Pinned to a full commit SHA (third-party action); comment tracks the tag.
uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5
uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5.4.2
with:
version: "${{ env.UV_VERSION }}"
enable-cache: true
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/test_github_release_workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ def test_release_workflow_tags_the_merged_pr_commit() -> None:
workflow = WORKFLOW.read_text(encoding="utf-8")

assert "ref: ${{ github.event.pull_request.merge_commit_sha }}" in workflow
assert "persist-credentials: false" in workflow
assert '--target "${{ github.event.pull_request.merge_commit_sha }}"' in workflow


Expand All @@ -56,7 +57,7 @@ def test_release_workflow_uses_skillspectors_locked_uv_environment() -> None:
"""Release artifacts are built with the repository's pinned tooling."""
workflow = WORKFLOW.read_text(encoding="utf-8")

assert "astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5" in workflow
assert "astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5.4.2" in workflow
assert 'UV_VERSION: "0.10.10"' in workflow
assert 'version: "${{ env.UV_VERSION }}"' in workflow
assert "cache-dependency-glob: uv.lock" in workflow
Expand Down