Repository navigation
fix(yara): require a browser cookie-store path in info_stealer #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elliottwaves-20
wants to merge
3
commits into
NVIDIA:main
Choose a base branch
from
elliottwaves-20:fix/751-info-stealer-cookie-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
3444dd5
fix(yara): require a browser cookie-store path in info_stealer
elliottwaves-20 9a5125a
fix(yara): keep info_stealer matches on code that names the store first
elliottwaves-20 db2c857
fix(yara): count a quote in info_stealer only around the browser name
elliottwaves-20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocker (fix together with the rule):
$cookies_browserstill matches English possessives because'is in its trailing class[\\\/'\x22(]. For example,Third-party cookies are blocked by Chrome's tracking protection.andSession cookies are dropped by Firefox's Enhanced Tracking Protection.both still get HIGHYR1. Please add both sentences to this list, and count a quote only when it encloses the browser name, as in['\x22](chrome|...)['\x22]. Keep(_|\.\w|[\\\/(])for identifiers and paths.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in db2c857: a quote now counts only when it encloses the browser name, and both sentences are in
_COOKIE_PROSE(plusCookies: Chrome/Edge supported, which matched through the slash). Details in the PR comment above.