docs: require issues before contribution PRs#343
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (20).agents/skills/**⚙️ CodeRabbit configuration file
Files:
.agents/skills/contribute-docs/**⚙️ CodeRabbit configuration file
Files:
**/*.{md,rst,html,txt}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Files:
**/*.{md,rst,html}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Files:
**/*.md📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
Files:
**/{docs,examples,**/*.md,*.patch,*.diff,.github,*.sh,*.yaml,*.yml}📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Files:
**/*.{md,rst,txt}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Files:
**/*.{md,rst}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Files:
{docs/**,README.md,CONTRIBUTING.md}📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
{docs/**,README.md,CONTRIBUTING.md,**/*.md}📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
{docs/**,README.md,**/Cargo.toml,**/package.json,**/*.md}📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
**/*.{rs,py,js,ts,tsx,jsx,go,sh,toml,yaml,yml,md}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{md,mdx}📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Files:
**⚙️ CodeRabbit configuration file
Files:
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}⚙️ CodeRabbit configuration file
Files:
{docs/**,README.md}📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
{docs/**,examples/**,README.md}📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
**/*.mdx📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
Files:
{RELEASING.md,CHANGELOG.md,docs/**/*.{md,mdx}}📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Files:
docs/**/*.{md,mdx}📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Files:
🧠 Learnings (1)📓 Common learnings🔇 Additional comments (3)
WalkthroughDocumentation updates require contributors to open or identify an issue before submitting a pull request. Changes span the contribute-docs skill rules, CONTRIBUTING.md's "Before Submitting" checklist, and workflow-and-reviews.mdx, with checklist items renumbered accordingly. ChangesIssue-linking requirement in contribution docs
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested labels: documentation Suggested reviewers: none identified Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
lvojtku
left a comment
There was a problem hiding this comment.
Approved without comments
|
/merge |
Overview
Require contributors to open or identify an issue before submitting enhancement or bug-fix pull requests. External contributors should use GitHub issues; NVIDIA contributors may use GitHub or Linear issues.
Details
Where should the reviewer start?
Start with the PR checklist changes in CONTRIBUTING.md and docs/contribute/workflow-and-reviews.mdx.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit