Skip to content

Deprecate examples/llm_autodeploy#1796

Merged
kevalmorabia97 merged 1 commit into
mainfrom
fridah/deprecate-llm-autodeploy
Jun 23, 2026
Merged

Deprecate examples/llm_autodeploy#1796
kevalmorabia97 merged 1 commit into
mainfrom
fridah/deprecate-llm-autodeploy

Conversation

@Fridah-nv

@Fridah-nv Fridah-nv commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Type of change: deprecation

Mark the AutoQuant + TensorRT-LLM AutoDeploy example as deprecated per the deprecation policy: add a deprecation banner to the example README and a note under the 0.45 Deprecations section of the changelog. The example will be removed in a future release; users should use TensorRT-LLM's AutoDeploy directly together with ModelOpt PTQ in examples/llm_ptq.

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

Make sure you read and follow Contributor guidelines and your commits are signed (git commit -s -S).

Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded trust_remote_code=True, torch.load(..., weights_only=False), pickle, etc.).

  • Is this change backward compatible?: ❌
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: ✅
  • Did you write any new necessary tests?: N/A
  • Did you update Changelog?: ✅
  • Did you get Claude approval on this PR?: ✅ / ❌ / N/A

Additional Information

Summary by CodeRabbit

  • Deprecations
    • The examples/llm_autodeploy example is deprecated and will be removed in a future release. Users should migrate to TensorRT-LLM's AutoDeploy directly with ModelOpt PTQ instead.

Mark the AutoQuant + TensorRT-LLM AutoDeploy example as deprecated per the
deprecation policy: add a deprecation banner to the example README and a
note under the 0.45 Deprecations section of the changelog. The example will
be removed in a future release; users should use TensorRT-LLM's AutoDeploy
directly together with ModelOpt PTQ in examples/llm_ptq.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 29791383-287c-4833-9e4b-e0bf56e6bcf4

📥 Commits

Reviewing files that changed from the base of the PR and between 090b1c5 and ed531df.

📒 Files selected for processing (2)
  • CHANGELOG.rst
  • examples/llm_autodeploy/README.md

📝 Walkthrough

Walkthrough

Two documentation files are updated to mark examples/llm_autodeploy as deprecated in ModelOpt 0.45. CHANGELOG.rst adds a Deprecations bullet, and examples/llm_autodeploy/README.md inserts a warning block at the top, both pointing users to TensorRT-LLM's AutoDeploy combined with ModelOpt PTQ in examples/llm_ptq.

Changes

Deprecation notices for llm_autodeploy

Layer / File(s) Summary
Deprecation notices in CHANGELOG and README
CHANGELOG.rst, examples/llm_autodeploy/README.md
CHANGELOG.rst adds a Deprecations entry for examples/llm_autodeploy with removal timeline. README.md inserts a [!WARNING] block at the top referencing ModelOpt 0.45 and linking to the recommended alternative workflow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Deprecate examples/llm_autodeploy' directly and accurately summarizes the main change in the pull request, which marks the AutoQuant + TensorRT-LLM AutoDeploy example as deprecated.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Anti-Patterns ✅ Passed PR only adds documentation (deprecation notice in CHANGELOG.rst and README.md); no Python code changes. Existing llm_autodeploy code has no security anti-patterns: no hardcoded trust_remote_code=Tr...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fridah/deprecate-llm-autodeploy

Comment @coderabbitai help to get the list of available commands.

@Fridah-nv Fridah-nv added the cherry-pick-0.45.0 After code freeze, cherry-pick to release branch for next rc (bulk update). Only for bug fixes / doc label Jun 22, 2026
@Fridah-nv

Copy link
Copy Markdown
Contributor Author

/claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude review passed — no blocking issues found. LGTM

Scope: Reviewed both changed files (CHANGELOG.rst, examples/llm_autodeploy/README.md) — a docs-only deprecation, +11/-0.

Findings: CRITICAL: 0, IMPORTANT: 0, SUGGESTION: 0

Notes (non-blocking):

  • The changelog entry correctly lands in the 0.45 Deprecations section (0.45 starts at line 24, 0.44 at line 111), consistent with the README banner's "Deprecated (ModelOpt 0.45)" and the PR description.
  • Relative link ../llm_ptq/README.md resolves correctly to examples/llm_ptq/README.md (verified present); the AutoDeploy GitHub link and RST anchor are well-formed.
  • No source/mode/export/state surface is touched — the example code is unchanged, so there is no restore, registration, or backward-compat risk beyond the documented eventual removal.

Risk level: minimal.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.23%. Comparing base (d0ac6d7) to head (ed531df).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1796      +/-   ##
==========================================
+ Coverage   77.15%   77.23%   +0.08%     
==========================================
  Files         511      511              
  Lines       56513    56513              
==========================================
+ Hits        43603    43649      +46     
+ Misses      12910    12864      -46     
Flag Coverage Δ
examples 41.80% <ø> (-0.10%) ⬇️
unit 54.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97 kevalmorabia97 merged commit f83a23c into main Jun 23, 2026
43 checks passed
@kevalmorabia97 kevalmorabia97 deleted the fridah/deprecate-llm-autodeploy branch June 23, 2026 03:09
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-23 03:09 UTC

@kevalmorabia97 kevalmorabia97 added the cherry-pick-done Added by bot once PR is cherry-picked to the release branch label Jun 23, 2026
kevalmorabia97 pushed a commit that referenced this pull request Jun 23, 2026
Type of change: deprecation <!-- Use one of the following: Bug fix, new
feature, new example, new tests, documentation. -->

Mark the AutoQuant + TensorRT-LLM AutoDeploy example as deprecated per
the deprecation policy: add a deprecation banner to the example README
and a note under the 0.45 Deprecations section of the changelog. The
example will be removed in a future release; users should use
TensorRT-LLM's AutoDeploy directly together with ModelOpt PTQ in
examples/llm_ptq.

```python
```
<!-- Mention how have you tested your change if applicable. -->

Make sure you read and follow [Contributor
guidelines](https://github.com/NVIDIA/Model-Optimizer/blob/main/CONTRIBUTING.md)
and your commits are signed (`git commit -s -S`).

Make sure you read and follow the [Security Best
Practices](https://github.com/NVIDIA/Model-Optimizer/blob/main/SECURITY.md#security-coding-practices-for-contributors)
(e.g. avoiding hardcoded `trust_remote_code=True`, `torch.load(...,
weights_only=False)`, `pickle`, etc.).

- Is this change backward compatible?: ❌ <!--- If ❌, explain why. -->
- If you copied code from any other sources or added a new PIP
dependency, did you follow guidance in `CONTRIBUTING.md`: ✅ <!---
Mandatory -->
- Did you write any new necessary tests?: N/A <!--- Mandatory for new
features or examples. -->
- Did you update
[Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?:
✅ <!--- Only for new features, API changes, critical bug fixes or
backward incompatible changes. -->
- Did you get Claude approval on this PR?: ✅ / ❌ / N/A <!--- Run
`/claude review`. NVIDIA org members can self-trigger for complex
changes; orthogonal to CodeRabbit. -->
<!-- E.g. related issue. -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

* **Deprecations**
* The `examples/llm_autodeploy` example is deprecated and will be
removed in a future release. Users should migrate to TensorRT-LLM's
AutoDeploy directly with ModelOpt PTQ instead.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-0.45.0 After code freeze, cherry-pick to release branch for next rc (bulk update). Only for bug fixes / doc cherry-pick-done Added by bot once PR is cherry-picked to the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants