Deprecate examples/llm_autodeploy#1796
Conversation
Mark the AutoQuant + TensorRT-LLM AutoDeploy example as deprecated per the deprecation policy: add a deprecation banner to the example README and a note under the 0.45 Deprecations section of the changelog. The example will be removed in a future release; users should use TensorRT-LLM's AutoDeploy directly together with ModelOpt PTQ in examples/llm_ptq. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo documentation files are updated to mark ChangesDeprecation notices for llm_autodeploy
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/claude review |
There was a problem hiding this comment.
Claude review passed — no blocking issues found. LGTM
Scope: Reviewed both changed files (CHANGELOG.rst, examples/llm_autodeploy/README.md) — a docs-only deprecation, +11/-0.
Findings: CRITICAL: 0, IMPORTANT: 0, SUGGESTION: 0
Notes (non-blocking):
- The changelog entry correctly lands in the 0.45 Deprecations section (0.45 starts at line 24, 0.44 at line 111), consistent with the README banner's "Deprecated (ModelOpt 0.45)" and the PR description.
- Relative link
../llm_ptq/README.mdresolves correctly toexamples/llm_ptq/README.md(verified present); the AutoDeploy GitHub link and RST anchor are well-formed. - No source/mode/export/state surface is touched — the example code is unchanged, so there is no restore, registration, or backward-compat risk beyond the documented eventual removal.
Risk level: minimal.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1796 +/- ##
==========================================
+ Coverage 77.15% 77.23% +0.08%
==========================================
Files 511 511
Lines 56513 56513
==========================================
+ Hits 43603 43649 +46
+ Misses 12910 12864 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Type of change: deprecation <!-- Use one of the following: Bug fix, new feature, new example, new tests, documentation. --> Mark the AutoQuant + TensorRT-LLM AutoDeploy example as deprecated per the deprecation policy: add a deprecation banner to the example README and a note under the 0.45 Deprecations section of the changelog. The example will be removed in a future release; users should use TensorRT-LLM's AutoDeploy directly together with ModelOpt PTQ in examples/llm_ptq. ```python ``` <!-- Mention how have you tested your change if applicable. --> Make sure you read and follow [Contributor guidelines](https://github.com/NVIDIA/Model-Optimizer/blob/main/CONTRIBUTING.md) and your commits are signed (`git commit -s -S`). Make sure you read and follow the [Security Best Practices](https://github.com/NVIDIA/Model-Optimizer/blob/main/SECURITY.md#security-coding-practices-for-contributors) (e.g. avoiding hardcoded `trust_remote_code=True`, `torch.load(..., weights_only=False)`, `pickle`, etc.). - Is this change backward compatible?: ❌ <!--- If ❌, explain why. --> - If you copied code from any other sources or added a new PIP dependency, did you follow guidance in `CONTRIBUTING.md`: ✅ <!--- Mandatory --> - Did you write any new necessary tests?: N/A <!--- Mandatory for new features or examples. --> - Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?: ✅ <!--- Only for new features, API changes, critical bug fixes or backward incompatible changes. --> - Did you get Claude approval on this PR?: ✅ / ❌ / N/A <!--- Run `/claude review`. NVIDIA org members can self-trigger for complex changes; orthogonal to CodeRabbit. --> <!-- E.g. related issue. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Deprecations** * The `examples/llm_autodeploy` example is deprecated and will be removed in a future release. Users should migrate to TensorRT-LLM's AutoDeploy directly with ModelOpt PTQ instead. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
What does this PR do?
Type of change: deprecation
Mark the AutoQuant + TensorRT-LLM AutoDeploy example as deprecated per the deprecation policy: add a deprecation banner to the example README and a note under the 0.45 Deprecations section of the changelog. The example will be removed in a future release; users should use TensorRT-LLM's AutoDeploy directly together with ModelOpt PTQ in examples/llm_ptq.
Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: ✅Additional Information
Summary by CodeRabbit
examples/llm_autodeployexample is deprecated and will be removed in a future release. Users should migrate to TensorRT-LLM's AutoDeploy directly with ModelOpt PTQ instead.