Add nvfp4_mse and nvfp4_local_hessian options to the ptq script.#1113
Add nvfp4_mse and nvfp4_local_hessian options to the ptq script.#1113bkartal-dev wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughUpdated allowed quantization format lists: the Python auto-quantize whitelist now accepts Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Comment |
Signed-off-by: Bilal Kartal <bkartal@nvidia.com>
8278385 to
f8ee452
Compare
Edwardf0t1
left a comment
There was a problem hiding this comment.
Please fix the conflict.
Signed-off-by: bkartal-dev <bkartal@nvidia.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
==========================================
+ Coverage 70.16% 70.18% +0.02%
==========================================
Files 228 228
Lines 25952 25952
==========================================
+ Hits 18208 18214 +6
+ Misses 7744 7738 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
merge conflict is resolved. |
What does this PR do?
Type of change: Bugfix
Add newly added quant configs to the example PTQ script.
Testing
I have locally run auto_quantize with these two quant_configs, and obtained successfully exported HF artifacts.
Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: ✅ / ❌ / N/AAdditional Information
Summary by CodeRabbit
New Features
Bug Fixes / UX