Skip to content

chore: add hf retries to files #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mckornfield wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: add hf retries to files #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8abef9
chore: add hf retries to files
mckornfield Jun 12, 2026
042c44f
chore: more hf fixes
mckornfield Jun 15, 2026
fbac457
chore: lint fixes
mckornfield Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,9 @@ jobs:
env:
EXTRA: cpu
HF_TOKEN: ${{ secrets.HF_TOKEN }}
NMP_FILES_HF_RETRY_ATTEMPTS: "7"
NMP_FILES_HF_RETRY_INITIAL_DELAY_SECONDS: "1"
NMP_FILES_HF_RETRY_MAX_DELAY_SECONDS: "30"
PYTEST_WORKERS: "4"
_TYPER_FORCE_DISABLE_TERMINAL: "1"
- name: Upload test artifacts
Expand Down Expand Up @@ -855,6 +858,9 @@ jobs:
E2E_SERVICES_LOG_DIR: ${{ runner.temp }}/e2e-services-logs
NGC_API_KEY: ${{ secrets.NGC_REGISTRY_READ_TOKEN }}
HF_TOKEN: ${{ secrets.HF_TOKEN }}
NMP_FILES_HF_RETRY_ATTEMPTS: "7"
NMP_FILES_HF_RETRY_INITIAL_DELAY_SECONDS: "1"
NMP_FILES_HF_RETRY_MAX_DELAY_SECONDS: "30"
- name: Dump server logs
if: always()
run: |
Expand Down
6 changes: 6 additions & 0 deletions docs/set-up/config-reference.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,12 @@ files:
file_lock_ttl_seconds: 300
# Maximum concurrent downloads during cache warming | default: 3
cache_warming_max_concurrent: 3
# Maximum Hugging Face request attempts for transient failures. | default: 4
hf_retry_attempts: 4
# Initial Hugging Face retry delay in seconds before exponential backoff. | default: 0.5
hf_retry_initial_delay_seconds: 0.5
# Maximum Hugging Face retry delay in seconds. | default: 5.0
hf_retry_max_delay_seconds: 5.0
```

### `inference_gateway`
Expand Down
2 changes: 2 additions & 0 deletions sdk/python/nemo-platform/.nmpcontext/stainless.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/python/nemo-platform/src/nemo_platform/resources/files/api.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion sdk/python/nemo-platform/src/nemo_platform/resources/files/filesets.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions sdk/python/nemo-platform/src/nemo_platform/types/__init__.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions sdk/python/nemo-platform/src/nemo_platform/types/files/__init__.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/python/nemo-platform/src/nemo_platform/types/files/fileset.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion sdk/python/nemo-platform/src/nemo_platform/types/files/fileset_create_params.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 0 additions & 47 deletions sdk/python/nemo-platform/src/nemo_platform/types/files/fileset_metadata_param.py
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions sdk/python/nemo-platform/src/nemo_platform/types/shared/__init__.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ..._platform/types/files/fileset_metadata.py → ...platform/types/shared/fileset_metadata.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions sdk/python/nemo-platform/src/nemo_platform/types/shared_params/fileset_metadata_param.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions sdk/stainless.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,3 +927,5 @@ resources:
experiment_session_responses_page: ExperimentSessionResponsesPage
methods:
list: get /apis/intake/v2/workspaces/{workspace}/experiments/{name}/sessions
methods:
create: post /apis/auth/v2/authz/{entrypoint}
1 change: 1 addition & 0 deletions services/core/auth/src/nmp/core/auth/assets/static-authz.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ authz:
description: "Read and write access to workspace resources"
includes: ["Viewer"]
permissions:
- auth.authz.create

@coderabbitai coderabbitai Bot Jun 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Undeclared permission key in role grant.

Editor now grants auth.authz.create, but authz.permissions has no auth.authz.create entry. This breaks the policy’s own registry contract and can make the grant ineffective or inconsistent at evaluation time.

Suggested fix 
 authz:
   permissions:
+    auth:
+      authz:
+        create:
+          description: "Create authorization resources"
+          # set explicitly based on enforcement path:
+          # has_endpoint: false
     entities:
       create:
         description: "Create entities"
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@services/core/auth/src/nmp/core/auth/assets/static-authz.yaml` at line 324,
The permission key `auth.authz.create` is being granted in the `Editor` role but
is not declared in the `authz.permissions` registry section of the YAML file.
Add a declaration for the `auth.authz.create` permission in the
`authz.permissions` section to ensure consistency with the policy's registry
contract and prevent evaluation-time issues. The new permission entry should
follow the same format and structure as existing permission declarations in that
section.

- filesets.create
- filesets.delete
- filesets.update
Expand Down
Loading
Loading