Skip to content

Add functional support matrix to README#4333

Merged
yaoyu-33 merged 2 commits into
mainfrom
snowmanwwg-patch-3
Jun 13, 2026
Merged

Add functional support matrix to README#4333
yaoyu-33 merged 2 commits into
mainfrom
snowmanwwg-patch-3

Conversation

@snowmanwwg

Copy link
Copy Markdown
Contributor

Added a broad functional support matrix to the README.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI section in the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Added a broad functional support matrix to the README.

Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com>
Comment thread README.md Outdated
@claude

claude Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Light Code Review

Docs-only change — small and straightforward. One typo flagged inline:

  • Typo: "SFT Lora" in the table header should be "SFT LoRA" (capital A) to match "RL LoRA" in the same row and the standard acronym.

Everything else looks good.

Suggested test cases

No perf tests impacted.

@yaoyu-33 yaoyu-33 added area:misc Cross-cutting utilities, logging, helpers, and other changes docs Documentation-only updates or documentation debt docs-only With great power comes great responsibility. needs-review PR is ready for code review and waiting on a reviewer labels Jun 12, 2026
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
@yaoyu-33 yaoyu-33 added the r0.5.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. label Jun 12, 2026
@yaoyu-33

Copy link
Copy Markdown
Contributor

/ok to test a04fb76

@yaoyu-33 yaoyu-33 merged commit a83a15c into main Jun 13, 2026
36 checks passed
@yaoyu-33 yaoyu-33 deleted the snowmanwwg-patch-3 branch June 13, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:misc Cross-cutting utilities, logging, helpers, and other changes docs Documentation-only updates or documentation debt docs-only With great power comes great responsibility. needs-review PR is ready for code review and waiting on a reviewer r0.5.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants